From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751771AbdKUPST (ORCPT ); Tue, 21 Nov 2017 10:18:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47825 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbdKUPSR (ORCPT ); Tue, 21 Nov 2017 10:18:17 -0500 Date: Tue, 21 Nov 2017 16:18:14 +0100 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation Message-ID: <20171121151814.GK20440@krava> References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-9-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511189024-19908-9-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 21 Nov 2017 15:18:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 10:43:43PM +0800, Jin Yao wrote: SNIP > - if ((stat_config.aggr_mode == AGGR_THREAD) && !target__has_task(&target)) { > - fprintf(stderr, "The --per-thread option is only available " > - "when monitoring via -p -t options.\n"); > - parse_options_usage(NULL, stat_options, "p", 1); > - parse_options_usage(NULL, stat_options, "t", 1); > - goto out; > + if ((stat_config.aggr_mode == AGGR_THREAD) && > + !target__has_task(&target)) { > + if (!target.system_wide || target.cpu_list) { > + fprintf(stderr, "The --per-thread option is only " > + "available when monitoring via -p -t " > + "options.\n"); the message should be updated with '-a' option, that you just added, also why dont we support target.cpu_list, it should work no? jirka