From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751867AbdKUPSi (ORCPT ); Tue, 21 Nov 2017 10:18:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60366 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353AbdKUPSe (ORCPT ); Tue, 21 Nov 2017 10:18:34 -0500 Date: Tue, 21 Nov 2017 16:18:32 +0100 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation Message-ID: <20171121151831.GM20440@krava> References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-9-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511189024-19908-9-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 21 Nov 2017 15:18:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 10:43:43PM +0800, Jin Yao wrote: > Currently, if we execute 'perf stat --per-thread' without specifying > pid/tid, perf will return error. > > root@skl:/tmp# perf stat --per-thread > The --per-thread option is only available when monitoring via -p -t options. > -p, --pid stat events on existing process id > -t, --tid stat events on existing thread id > > This patch removes this limitation. If no pid/tid specified, it returns > all threads (get threads from /proc). > > Signed-off-by: Jin Yao > --- > tools/perf/builtin-stat.c | 23 +++++++++++++++-------- > tools/perf/util/target.h | 7 +++++++ > 2 files changed, 22 insertions(+), 8 deletions(-) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index 9eec145..2d718f7 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -277,7 +277,7 @@ static int create_perf_stat_counter(struct perf_evsel *evsel) > attr->enable_on_exec = 1; > } > > - if (target__has_cpu(&target)) > + if (target__has_cpu(&target) && !target__has_per_thread(&target)) please add comment on why this is needed.. > return perf_evsel__open_per_cpu(evsel, perf_evsel__cpus(evsel)); > > return perf_evsel__open_per_thread(evsel, evsel_list->threads); > @@ -340,7 +340,7 @@ static int read_counter(struct perf_evsel *counter) > int nthreads = thread_map__nr(evsel_list->threads); > int ncpus, cpu, thread; > > - if (target__has_cpu(&target)) > + if (target__has_cpu(&target) && !target__has_per_thread(&target)) same here thanks, jirka