From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbdKUTL0 (ORCPT ); Tue, 21 Nov 2017 14:11:26 -0500 Received: from mail-wr0-f170.google.com ([209.85.128.170]:45445 "EHLO mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238AbdKUTLZ (ORCPT ); Tue, 21 Nov 2017 14:11:25 -0500 X-Google-Smtp-Source: AGs4zMYsywy+pj3SdVyyy/R3RP5jKO1/niv+1KobAOI2TEx2X01ePLVd81CUUDsLBTkUEdYNkciBng== Date: Tue, 21 Nov 2017 22:11:21 +0300 From: Alexey Dobriyan To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, mahesh@linux.vnet.ibm.com Subject: [PATCH] proc: simpler /proc/vmcore cleanup Message-ID: <20171121191121.GA20757@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Iterators aren't necessary as you can just grab the first entry and delete it until no entries left. Signed-off-by: Alexey Dobriyan --- fs/proc/vmcore.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -1178,18 +1178,16 @@ fs_initcall(vmcore_init); /* Cleanup function for vmcore module. */ void vmcore_cleanup(void) { - struct list_head *pos, *next; - if (proc_vmcore) { proc_remove(proc_vmcore); proc_vmcore = NULL; } /* clear the vmcore list. */ - list_for_each_safe(pos, next, &vmcore_list) { + while (!list_empty(&vmcore_list)) { struct vmcore *m; - m = list_entry(pos, struct vmcore, list); + m = list_first_entry(&vmcore_list, struct vmcore, list); list_del(&m->list); kfree(m); }