From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751525AbdKVIaa (ORCPT ); Wed, 22 Nov 2017 03:30:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41902 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbdKVIa2 (ORCPT ); Wed, 22 Nov 2017 03:30:28 -0500 Date: Wed, 22 Nov 2017 09:30:25 +0100 From: Jiri Olsa To: "Jin, Yao" Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats Message-ID: <20171122083025.GB30707@krava> References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-4-git-send-email-yao.jin@linux.intel.com> <20171121151700.GA20440@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 22 Nov 2017 08:30:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 22, 2017 at 09:29:26AM +0800, Jin, Yao wrote: > > > On 11/21/2017 11:17 PM, Jiri Olsa wrote: > > On Mon, Nov 20, 2017 at 10:43:38PM +0800, Jin Yao wrote: > > > > SNIP > > > > > +static void init_saved_rblist(struct rblist *rblist) > > > +{ > > > + rblist__init(rblist); > > > + rblist->node_cmp = saved_value_cmp; > > > + rblist->node_new = saved_value_new; > > > + rblist->node_delete = saved_value_delete; > > > +} > > > + > > > +static void free_saved_rblist(struct rblist *rblist) > > > +{ > > > + rblist__reset(rblist); > > > +} > > > + > > > +void perf_stat__init_runtime_stat(struct runtime_stat *stat) > > > +{ > > > + memset(stat, 0, sizeof(struct runtime_stat)); > > > > what's this memset for? that struct has only rb_list > > > > jirka > > > > Currently this struct has only rblist. I use memset to zero this struct is > for future potential new added fields to this struct. > > If it's not good, I will remove this memset. ok, np jirka