From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777AbdKVIhZ (ORCPT ); Wed, 22 Nov 2017 03:37:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42314 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbdKVIhY (ORCPT ); Wed, 22 Nov 2017 03:37:24 -0500 Date: Wed, 22 Nov 2017 09:37:21 +0100 From: Jiri Olsa To: "Jin, Yao" Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 4/9] perf util: Update and print per-thread shadow stats Message-ID: <20171122083721.GE30707@krava> References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-5-git-send-email-yao.jin@linux.intel.com> <20171121151800.GI20440@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 22 Nov 2017 08:37:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 22, 2017 at 11:10:37AM +0800, Jin, Yao wrote: > > > On 11/21/2017 11:18 PM, Jiri Olsa wrote: > > On Mon, Nov 20, 2017 at 10:43:39PM +0800, Jin Yao wrote: > > > > SNIP > > > > > if (num == 0) > > > diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c > > > index 151e9ef..50bb16d 100644 > > > --- a/tools/perf/util/stat.c > > > +++ b/tools/perf/util/stat.c > > > @@ -278,9 +278,16 @@ process_counter_values(struct perf_stat_config *config, struct perf_evsel *evsel > > > perf_evsel__compute_deltas(evsel, cpu, thread, count); > > > perf_counts_values__scale(count, config->scale, NULL); > > > if (config->aggr_mode == AGGR_NONE) > > > - perf_stat__update_shadow_stats(evsel, count->val, cpu); > > > - if (config->aggr_mode == AGGR_THREAD) > > > - perf_stat__update_shadow_stats(evsel, count->val, 0); > > > + perf_stat__update_shadow_stats(evsel, count->val, cpu, > > > + NULL); > > > + if (config->aggr_mode == AGGR_THREAD) { > > > + if (config->stats) > > > + perf_stat__update_shadow_stats(evsel, > > > + count->val, 0, &config->stats[thread]); > > > > please add this part together with config->stats allocation/usage > > and keep this change only about adding the struct runtime_stat *stat > > into the code path with no functional change > > > > thanks, > > jirka > > > > The interface of perf_stat__update_shadow_stats() is changed (added with a > new parameter 'struct runtime_stat *stat'). > > If I move above part to another patch (e.g. move to > v1-0006-perf-stat-Allocate-shadow-stats-buffer-for-thread.patch), the > compilation would be failed if only applying with this patch. It's not good > for git bisect. but you could make the patch just to add the 'struct runtime_stat *stat' as an argument through the code path.. as a base for the stats, no? jirka