From: Guilherme Tadashi Maeoka <gui.maeoka@gmail.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: adl_pci9118: fixed some parentheses coding style issue
Date: Wed, 22 Nov 2017 09:50:03 -0200 [thread overview]
Message-ID: <20171122115003.GA6751@uts> (raw)
In-Reply-To: <20171122002851.GW7472@eros>
Thank you. I'll keep that in mind next time!
On Wed, Nov 22, 2017 at 11:28:51AM +1100, Tobin C. Harding wrote:
> You may like to limit the git log brief description to 50 characters
> (this is going to be hard with such a long pre-fix though :)
>
> Brief description should be in imperative mood i.e 'Fix foo' instead of
> 'fixed foo'.
>
> On Tue, Nov 21, 2017 at 05:17:53PM -0200, Guilherme Tadashi Maeoka wrote:
> > Fixed some code style issues.
>
> This is not descriptive enough. You may like to read
>
> Documentation/process/submitting-patches.rst
>
> for tips on writing git log messages.
>
> > Signed-off-by: Guilherme Tadashi Maeoka <gui.maeoka@gmail.com>
> > ---
> > drivers/staging/comedi/drivers/adl_pci9118.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
> > index 1cc9b7ef1ff9..53f13994ac94 100644
> > --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> > +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> > @@ -947,7 +947,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> > if (devpriv->master) {
> > devpriv->usedma = 1;
> > if ((cmd->flags & CMDF_WAKE_EOS) &&
> > - (cmd->scan_end_arg == 1)) {
> > + cmd->scan_end_arg == 1) {
>
> The code was easier to read before this change IMO.
>
> > if (cmd->convert_src == TRIG_NOW)
> > devpriv->ai_add_back = 1;
> > if (cmd->convert_src == TRIG_TIMER) {
> > @@ -960,7 +960,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> > }
> > if ((cmd->flags & CMDF_WAKE_EOS) &&
> > (cmd->scan_end_arg & 1) &&
> > - (cmd->scan_end_arg > 1)) {
> > + cmd->scan_end_arg > 1) {
> > if (cmd->scan_begin_src == TRIG_FOLLOW) {
> > devpriv->usedma = 0;
> > /*
> > @@ -983,7 +983,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> > */
> > if (cmd->convert_src == TRIG_NOW && devpriv->softsshdelay) {
> > devpriv->ai_add_front = 2;
> > - if ((devpriv->usedma == 1) && (devpriv->ai_add_back == 1)) {
> > + if (devpriv->usedma == 1 && devpriv->ai_add_back == 1) {
>
> Likewise, this is not making the code easier to read.
>
> > /* move it to front */
> > devpriv->ai_add_front++;
> > devpriv->ai_add_back = 0;
> > @@ -1185,7 +1185,7 @@ static int pci9118_ai_cmdtest(struct comedi_device *dev,
> > (!(cmd->convert_src & (TRIG_TIMER | TRIG_NOW))))
> > err |= -EINVAL;
> >
> > - if ((cmd->scan_begin_src == TRIG_FOLLOW) &&
> > + if (cmd->scan_begin_src == TRIG_FOLLOW &&
> > (!(cmd->convert_src & (TRIG_TIMER | TRIG_EXT))))
> > err |= -EINVAL;
> >
> > @@ -1210,8 +1210,8 @@ static int pci9118_ai_cmdtest(struct comedi_device *dev,
> > if (cmd->scan_begin_src & (TRIG_FOLLOW | TRIG_EXT))
> > err |= comedi_check_trigger_arg_is(&cmd->scan_begin_arg, 0);
> >
> > - if ((cmd->scan_begin_src == TRIG_TIMER) &&
> > - (cmd->convert_src == TRIG_TIMER) && (cmd->scan_end_arg == 1)) {
> > + if (cmd->scan_begin_src == TRIG_TIMER &&
> > + cmd->convert_src == TRIG_TIMER && cmd->scan_end_arg == 1) {
> > cmd->scan_begin_src = TRIG_FOLLOW;
> > cmd->convert_arg = cmd->scan_begin_arg;
> > cmd->scan_begin_arg = 0;
>
> Remember, we are writing code for developers to read. It should be as
> easy to parse as possible.
>
> Hope this helps,
> Tobin.
prev parent reply other threads:[~2017-11-22 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 19:17 [PATCH] Staging: comedi: adl_pci9118: fixed some parentheses coding style issue Guilherme Tadashi Maeoka
2017-11-22 0:28 ` Tobin C. Harding
2017-11-22 11:50 ` Guilherme Tadashi Maeoka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171122115003.GA6751@uts \
--to=gui.maeoka@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).