From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751935AbdKVPeS (ORCPT ); Wed, 22 Nov 2017 10:34:18 -0500 Received: from mail-pl0-f51.google.com ([209.85.160.51]:35503 "EHLO mail-pl0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbdKVPeQ (ORCPT ); Wed, 22 Nov 2017 10:34:16 -0500 X-Google-Smtp-Source: AGs4zMbnCoWTRDgA4uGLDT8gVtfv9Jxe8qOswrtWRZJS+qUx+bwOGxtw0IZyhO2gI7z8faeBrRMFQw== Date: Wed, 22 Nov 2017 07:34:10 -0800 From: Eduardo Valentin To: Sudeep Holla Cc: Javi Merino , Vincent Guittot , Lukasz Luba , Daniel Lezcano , Ionela Voinescu , Punit Agrawal , "Rafael J. Wysocki" , Viresh Kumar , "Rafael J. Wysocki" , Amit Daniel Kachhap , Zhang Rui , Steven Rostedt , Ingo Molnar , Linux PM , Lukasz Luba , Linux Kernel Mailing List Subject: Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff Message-ID: <20171122153407.GA24699@localhost.localdomain> References: <20171116234422.GA6141@localhost.localdomain> <878tf5tbfj.fsf@e105922-lin.cambridge.arm.com> <35d3751d-f28d-38c2-02b2-c9980f11c52e@arm.com> <5A144CB3.50806@gmail.com> <20171121165703.GA2499@localhost.localdomain> <20171121180006.GA26638@localhost> <20171121181222.GA4075@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 22, 2017 at 10:59:21AM +0000, Sudeep Holla wrote: > (sorry for chiming in quite late) > > On 21/11/17 18:12, Eduardo Valentin wrote: > > On Tue, Nov 21, 2017 at 06:00:07PM +0000, Javi Merino wrote: > >> Hi, > >> > >> On Tue, Nov 21, 2017 at 08:57:06AM -0800, Eduardo Valentin wrote: > >> > > [...] > > >> > >> In a nutshell, mainline does not want platform specific code, but we > >> haven't figured out how to calculate static power without platform > >> specific code.> > > To, that is still fine to have it as a callback, as long as you have at > > least one user! I still do not understand why Juno static power cannot > > go as platform code that register the callback to implement the static > > power model. > > > > 1. It was proved not so useful(anyone can prove otherwise ?) Can anyone prove it does not have static power? > 2. I am told static power is negligible compared to dynamic power with > new fab processes. I am told quantum computer is out there :-), does it mean we should drop the maintenance of everything else? > 3. It's very hard to even test IPA on Juno as it doesn't reach the > required critical temperature easily. So as Juno platform maintainer > I want a test case to test regression before we merge anything. > > IMO, if the $subject code is expected to be used on Juno, then my answer > is no if one can't test it reliably and also prove that static power > really matters on Juno. So far, I have heard both the above is not > possible. So please delete the code if Juno is the only user in > short and mid term. We can get the code back if we find any users in > longer term. Yeah, the fact that Juno takes time to reach crit temperature does not necessarily imply it does not have static power consumption, or that its static power consumption is negligible. Now, if you want to ignore it, because it is not the best example to show usefulness of IPA, that is a different story. Eduardo > > -- > Regards, > Sudeep