From: Peter Zijlstra <peterz@infradead.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Sebastian Ott <sebott@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [bisected] system hang after boot
Date: Wed, 22 Nov 2017 21:22:17 +0100 [thread overview]
Message-ID: <20171122202217.GO3326@worktop> (raw)
In-Reply-To: <20171122182659.GA22648@arm.com>
On Wed, Nov 22, 2017 at 06:26:59PM +0000, Will Deacon wrote:
> Now, I can't see what the break_lock is doing here other than causing
> problems. Is there a good reason for it, or can you just try removing it
> altogether? Patch below.
The main use is spin_is_contended(), which in turn ends up used in
__cond_resched_lock() through spin_needbreak().
This allows better lock wait times for PREEMPT kernels on platforms
where the lock implementation itself cannot provide 'contended' state.
In that capacity the write-write race shouldn't be a problem though.
That said, I'd not be horribly sad to see this go, I've always found it
to be quite the ugly hack and taking it out should provide some
incentive for better lock implementations for the archs relying on this.
next prev parent reply other threads:[~2017-11-22 20:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 17:46 [bisected] system hang after boot Sebastian Ott
2017-11-22 18:26 ` Will Deacon
2017-11-22 18:54 ` Sebastian Ott
2017-11-22 19:10 ` Will Deacon
2017-11-22 20:22 ` Peter Zijlstra [this message]
2017-11-27 11:49 ` Will Deacon
2017-11-27 12:45 ` Will Deacon
2017-11-27 13:05 ` Sebastian Ott
2017-11-27 12:49 ` Martin Schwidefsky
2017-11-27 12:54 ` Will Deacon
2017-11-27 13:00 ` Martin Schwidefsky
2017-11-27 13:10 ` Will Deacon
2017-11-27 13:13 ` Peter Zijlstra
2017-11-27 13:12 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171122202217.GO3326@worktop \
--to=peterz@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox