The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: alexander.levin@verizon.com
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Subhash Jadavani <subhashj@codeaurora.org>,
	Vijay Viswanath <vviswana@codeaurora.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alexander.levin@verizon.com
Subject: [PATCH AUTOSEL for 4.14 15/51] mmc: sdhci-msm: fix issue with power irq
Date: Wed, 22 Nov 2017 22:25:39 +0000	[thread overview]
Message-ID: <20171122222526.20021-15-alexander.levin@verizon.com> (raw)
In-Reply-To: <20171122222526.20021-1-alexander.levin@verizon.com>

From: Subhash Jadavani <subhashj@codeaurora.org>

[ Upstream commit c7ccee224d2d551f712752c4a16947f6529d6506 ]

SDCC controller reset (SW_RST) during probe may trigger power irq if
previous status of PWRCTL was either BUS_ON or IO_HIGH_V. So before we
enable the power irq interrupt in GIC (by registering the interrupt
handler), we need to ensure that any pending power irq interrupt status
is acknowledged otherwise power irq interrupt handler would be fired
prematurely.

Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Vijay Viswanath <vviswana@codeaurora.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
 drivers/mmc/host/sdhci-msm.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index fc73e56eb1e2..92c483ec6cb2 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -1251,6 +1251,21 @@ static int sdhci_msm_probe(struct platform_device *pdev)
 			       CORE_VENDOR_SPEC_CAPABILITIES0);
 	}
 
+	/*
+	 * Power on reset state may trigger power irq if previous status of
+	 * PWRCTL was either BUS_ON or IO_HIGH_V. So before enabling pwr irq
+	 * interrupt in GIC, any pending power irq interrupt should be
+	 * acknowledged. Otherwise power irq interrupt handler would be
+	 * fired prematurely.
+	 */
+	sdhci_msm_voltage_switch(host);
+
+	/*
+	 * Ensure that above writes are propogated before interrupt enablement
+	 * in GIC.
+	 */
+	mb();
+
 	/* Setup IRQ for handling power/voltage tasks with PMIC */
 	msm_host->pwr_irq = platform_get_irq_byname(pdev, "pwr_irq");
 	if (msm_host->pwr_irq < 0) {
@@ -1260,6 +1275,9 @@ static int sdhci_msm_probe(struct platform_device *pdev)
 		goto clk_disable;
 	}
 
+	/* Enable pwr irq interrupts */
+	writel_relaxed(INT_MASK, msm_host->core_mem + CORE_PWRCTL_MASK);
+
 	ret = devm_request_threaded_irq(&pdev->dev, msm_host->pwr_irq, NULL,
 					sdhci_msm_pwr_irq, IRQF_ONESHOT,
 					dev_name(&pdev->dev), host);
-- 
2.11.0

  parent reply	other threads:[~2017-11-22 23:00 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22 22:25 [PATCH AUTOSEL for 4.14 01/51] ima: fix hash algorithm initialization alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 03/51] PM / Domains: Fix genpd to deal with drivers returning 1 from ->prepare() alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 02/51] s390: vfio-ccw: Do not attempt to free no-op, test and tic cda alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 04/51] s390/pci: do not require AIS facility alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 06/51] selftests/x86/ldt_gdt: Robustify against set_thread_area() and LAR oddities alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 08/51] m68k: fix ColdFire node shift size calculation alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 07/51] staging: greybus: loopback: Fix iteration count on async path alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 05/51] selftests/x86/ldt_get: Add a few additional tests for limits alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 11/51] staging: rtl8188eu: avoid a null dereference on pmlmepriv alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 09/51] serial: 8250_fintek: Fix rs485 disablement on invalid ioctl() alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 10/51] staging: rtl8822be: fix wrong dma unmap len alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 12/51] spi: sh-msiof: Fix DMA transfer size check alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 14/51] mmc: tmio: check mmc_regulator_get_supply return value alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 13/51] spi: spi-axi: fix potential use-after-free after deregistration alexander.levin
2017-11-22 22:25 ` alexander.levin [this message]
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 16/51] hwmon: (pmbus/core) Prevent unintentional setting of page to 0xFF alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 17/51] perf/core: Fix __perf_read_group_add() locking alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 20/51] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 19/51] usb: dwc2: Fix UDC state tracking alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 18/51] perf callchain: Compare symbol name for inlined frames when matching alexander.levin
2017-11-23  8:55   ` Milian Wolff
2017-11-28 15:12     ` alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 21/51] usb: phy: tahvo: fix error handling in tahvo_usb_probe() alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 23/51] x86/intel_rdt: Initialize bitmask of shareable resource if CDP enabled alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 22/51] PCI: dra7xx: Create functional dependency between PCIe and PHY alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 27/51] x86/entry: Use SYSCALL_DEFINE() macros for sys_modify_ldt() alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 25/51] serial: 8250: Preserve DLD[7:4] for PORT_XR17V35X alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 26/51] kprobes: Use synchronize_rcu_tasks() for optprobe with CONFIG_PREEMPT=y alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 24/51] x86/intel_rdt: Fix potential deadlock during resctrl mount alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 31/51] EDAC, sb_edac: Fix missing break in switch alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 30/51] irqchip/gic: Make quirks matching conditional on init return value alexander.levin
2017-11-23  8:50   ` Marc Zyngier
2017-11-28 15:13     ` alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 29/51] dt-bindings: timer: renesas, cmt: Fix SoC-specific compatible values alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 28/51] clocksource/drivers/arm_arch_timer: Validate CNTFRQ after enabling frame alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 36/51] usb: xhci: Return error when host is dead in xhci_disable_slot() alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 32/51] usb: mtu3: fix error return code in ssusb_gadget_init() alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 34/51] staging: rtl8822be: Keep array subscript no lower than zero alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 33/51] staging: fsl-dpaa2/eth: Account for Rx FD buffers on error path alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 35/51] ARM: cpuidle: Correct driver unregistration if init fails alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 38/51] serial: sh-sci: suppress warning for ports without dma channels alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 37/51] sysrq : fix Show Regs call trace on ARM alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 40/51] serial: imx: Update cached mctrl value when changing RTS alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 39/51] usbip: tools: Install all headers needed for libusbip development alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 43/51] perf test attr: Fix python error on empty result alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 44/51] kprobes/x86: Disable preemption in ftrace-based jprobes alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 42/51] perf test attr: Fix ignored test case result alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 41/51] staging: fsl-mc/dpio: Fix incorrect comparison alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 46/51] s390/ptrace: fix guarded storage regset handling alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 48/51] perf tools: Fix leaking rec_argv in error cases alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 47/51] tools include: Do not use poison with C++ alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 45/51] locking/refcounts, x86/asm: Use unique .text section for refcount exceptions alexander.levin
2017-11-22 23:19   ` Kees Cook
2017-11-23  1:13     ` alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 49/51] mm, x86/mm: Fix performance regression in get_user_pages_fast() alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 50/51] iio: adc: ti-ads1015: add 10% to conversion wait time alexander.levin
2017-11-22 22:25 ` [PATCH AUTOSEL for 4.14 51/51] iio: multiplexer: add NULL check on devm_kzalloc() and devm_kmemdup() return values alexander.levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171122222526.20021-15-alexander.levin@verizon.com \
    --to=alexander.levin@verizon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=subhashj@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vviswana@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox