* [PATCH] mfd: sm501: Add NULL check on devm_kzalloc return value
@ 2017-11-23 3:50 Gustavo A. R. Silva
2017-11-23 9:37 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-23 3:50 UTC (permalink / raw)
To: Lee Jones, Linus Walleij; +Cc: linux-kernel, Gustavo A. R. Silva
Check return value from call to devm_kzalloc() in order to prevent
a NULL pointer dereference.
This issue was detected with the help of Coccinelle.
Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/mfd/sm501.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index ad77416..08bee41 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -1144,6 +1144,9 @@ static int sm501_register_gpio_i2c_instance(struct sm501_devdata *sm,
lookup = devm_kzalloc(&pdev->dev,
sizeof(*lookup) + 3 * sizeof(struct gpiod_lookup),
GFP_KERNEL);
+ if (!lookup)
+ return -ENOMEM;
+
lookup->dev_id = "i2c-gpio";
if (iic->pin_sda < 32)
lookup->table[0].chip_label = "SM501-LOW";
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: sm501: Add NULL check on devm_kzalloc return value
2017-11-23 3:50 [PATCH] mfd: sm501: Add NULL check on devm_kzalloc return value Gustavo A. R. Silva
@ 2017-11-23 9:37 ` Linus Walleij
2017-11-27 12:58 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2017-11-23 9:37 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Lee Jones, linux-kernel@vger.kernel.org
On Thu, Nov 23, 2017 at 4:50 AM, Gustavo A. R. Silva
<garsilva@embeddedor.com> wrote:
> Check return value from call to devm_kzalloc() in order to prevent
> a NULL pointer dereference.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors")
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: sm501: Add NULL check on devm_kzalloc return value
2017-11-23 9:37 ` Linus Walleij
@ 2017-11-27 12:58 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-27 12:58 UTC (permalink / raw)
To: Linus Walleij; +Cc: Lee Jones, linux-kernel@vger.kernel.org
On 11/23/2017 03:37 AM, Linus Walleij wrote:
> On Thu, Nov 23, 2017 at 4:50 AM, Gustavo A. R. Silva
> <garsilva@embeddedor.com> wrote:
>
>> Check return value from call to devm_kzalloc() in order to prevent
>> a NULL pointer dereference.
>>
>> This issue was detected with the help of Coccinelle.
>>
>> Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors")
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
Thank you, Linus.
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-27 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-23 3:50 [PATCH] mfd: sm501: Add NULL check on devm_kzalloc return value Gustavo A. R. Silva
2017-11-23 9:37 ` Linus Walleij
2017-11-27 12:58 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox