* [PATCH 1/2] serial: 8250_fintek: Return -EINVAL on invalid configuration
@ 2017-11-06 10:49 Ricardo Ribalda Delgado
2017-11-06 10:49 ` [PATCH 2/2] serial: 8250_fintek: Disable delays for ports != 0 Ricardo Ribalda Delgado
2017-11-22 22:30 ` [PATCH 1/2] serial: 8250_fintek: Return -EINVAL on invalid configuration Ricardo Ribalda Delgado
0 siblings, 2 replies; 5+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-11-06 10:49 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Ji-Ze Hong (Peter Hong),
Lukas Wunner, linux-serial, linux-kernel
Cc: Ricardo Ribalda Delgado
Hardware does not support having the same RTS level during RX and TX
when RS485 mode is on (URA in Fintek terminology).
The manufacturer has also confirmed that the delays are not enabled if
the RS485 mode is not enabled.
Therefore we should return -EINVAL if the user wants to have the same
value for RTS_ON_SEND and RTS_AFTER_SEND.
Cc: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/tty/serial/8250/8250_fintek.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
index c41cbb52f1fe..ca7e96f9f080 100644
--- a/drivers/tty/serial/8250/8250_fintek.c
+++ b/drivers/tty/serial/8250/8250_fintek.c
@@ -201,10 +201,17 @@ static int fintek_8250_rs485_config(struct uart_port *port,
if (!pdata)
return -EINVAL;
- if (rs485->flags & SER_RS485_ENABLED)
+ /* Hardware do not support same RTS level on send and receive */
+ if (!(rs485->flags & SER_RS485_RTS_ON_SEND) ==
+ !(rs485->flags & SER_RS485_RTS_AFTER_SEND))
+ return -EINVAL;
+
+ if (rs485->flags & SER_RS485_ENABLED) {
memset(rs485->padding, 0, sizeof(rs485->padding));
- else
+ config |= RS485_URA;
+ } else {
memset(rs485, 0, sizeof(*rs485));
+ }
rs485->flags &= SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND |
SER_RS485_RTS_AFTER_SEND;
@@ -219,12 +226,6 @@ static int fintek_8250_rs485_config(struct uart_port *port,
config |= RXW4C_IRA;
}
- if ((!!(rs485->flags & SER_RS485_RTS_ON_SEND)) ==
- (!!(rs485->flags & SER_RS485_RTS_AFTER_SEND)))
- rs485->flags &= ~SER_RS485_ENABLED;
- else
- config |= RS485_URA;
-
if (rs485->flags & SER_RS485_RTS_ON_SEND)
config |= RTS_INVERT;
--
2.14.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] serial: 8250_fintek: Disable delays for ports != 0
2017-11-06 10:49 [PATCH 1/2] serial: 8250_fintek: Return -EINVAL on invalid configuration Ricardo Ribalda Delgado
@ 2017-11-06 10:49 ` Ricardo Ribalda Delgado
2017-11-22 22:31 ` Ricardo Ribalda Delgado
2017-11-22 22:30 ` [PATCH 1/2] serial: 8250_fintek: Return -EINVAL on invalid configuration Ricardo Ribalda Delgado
1 sibling, 1 reply; 5+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-11-06 10:49 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Ji-Ze Hong (Peter Hong),
Lukas Wunner, linux-serial, linux-kernel
Cc: Ricardo Ribalda Delgado
According to the datasheet, only the first port supports delay before
send and delay after send.
Reported-by: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/tty/serial/8250/8250_fintek.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
index ca7e96f9f080..61745d4bea31 100644
--- a/drivers/tty/serial/8250/8250_fintek.c
+++ b/drivers/tty/serial/8250/8250_fintek.c
@@ -216,6 +216,12 @@ static int fintek_8250_rs485_config(struct uart_port *port,
rs485->flags &= SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND |
SER_RS485_RTS_AFTER_SEND;
+ /* Only the first port supports delays */
+ if (pdata->index) {
+ rs485->delay_rts_before_send = 0;
+ rs485->delay_rts_after_send = 0;
+ }
+
if (rs485->delay_rts_before_send) {
rs485->delay_rts_before_send = 1;
config |= TXW4C_IRA;
--
2.14.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] serial: 8250_fintek: Disable delays for ports != 0
2017-11-06 10:49 ` [PATCH 2/2] serial: 8250_fintek: Disable delays for ports != 0 Ricardo Ribalda Delgado
@ 2017-11-22 22:31 ` Ricardo Ribalda Delgado
0 siblings, 0 replies; 5+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-11-22 22:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Ji-Ze Hong (Peter Hong),
Lukas Wunner, linux-serial, LKML
Cc: Ricardo Ribalda Delgado
ping?
On Mon, Nov 6, 2017 at 11:49 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> According to the datasheet, only the first port supports delay before
> send and delay after send.
>
> Reported-by: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> drivers/tty/serial/8250/8250_fintek.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> index ca7e96f9f080..61745d4bea31 100644
> --- a/drivers/tty/serial/8250/8250_fintek.c
> +++ b/drivers/tty/serial/8250/8250_fintek.c
> @@ -216,6 +216,12 @@ static int fintek_8250_rs485_config(struct uart_port *port,
> rs485->flags &= SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND |
> SER_RS485_RTS_AFTER_SEND;
>
> + /* Only the first port supports delays */
> + if (pdata->index) {
> + rs485->delay_rts_before_send = 0;
> + rs485->delay_rts_after_send = 0;
> + }
> +
> if (rs485->delay_rts_before_send) {
> rs485->delay_rts_before_send = 1;
> config |= TXW4C_IRA;
> --
> 2.14.2
>
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] serial: 8250_fintek: Return -EINVAL on invalid configuration
2017-11-06 10:49 [PATCH 1/2] serial: 8250_fintek: Return -EINVAL on invalid configuration Ricardo Ribalda Delgado
2017-11-06 10:49 ` [PATCH 2/2] serial: 8250_fintek: Disable delays for ports != 0 Ricardo Ribalda Delgado
@ 2017-11-22 22:30 ` Ricardo Ribalda Delgado
2017-11-23 5:03 ` Lukas Wunner
1 sibling, 1 reply; 5+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-11-22 22:30 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Ji-Ze Hong (Peter Hong),
Lukas Wunner, linux-serial, LKML
Cc: Ricardo Ribalda Delgado
ping?
On Mon, Nov 6, 2017 at 11:49 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> Hardware does not support having the same RTS level during RX and TX
> when RS485 mode is on (URA in Fintek terminology).
>
> The manufacturer has also confirmed that the delays are not enabled if
> the RS485 mode is not enabled.
>
> Therefore we should return -EINVAL if the user wants to have the same
> value for RTS_ON_SEND and RTS_AFTER_SEND.
>
> Cc: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
> Cc: Lukas Wunner <lukas@wunner.de>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> drivers/tty/serial/8250/8250_fintek.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> index c41cbb52f1fe..ca7e96f9f080 100644
> --- a/drivers/tty/serial/8250/8250_fintek.c
> +++ b/drivers/tty/serial/8250/8250_fintek.c
> @@ -201,10 +201,17 @@ static int fintek_8250_rs485_config(struct uart_port *port,
> if (!pdata)
> return -EINVAL;
>
> - if (rs485->flags & SER_RS485_ENABLED)
> + /* Hardware do not support same RTS level on send and receive */
> + if (!(rs485->flags & SER_RS485_RTS_ON_SEND) ==
> + !(rs485->flags & SER_RS485_RTS_AFTER_SEND))
> + return -EINVAL;
> +
> + if (rs485->flags & SER_RS485_ENABLED) {
> memset(rs485->padding, 0, sizeof(rs485->padding));
> - else
> + config |= RS485_URA;
> + } else {
> memset(rs485, 0, sizeof(*rs485));
> + }
>
> rs485->flags &= SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND |
> SER_RS485_RTS_AFTER_SEND;
> @@ -219,12 +226,6 @@ static int fintek_8250_rs485_config(struct uart_port *port,
> config |= RXW4C_IRA;
> }
>
> - if ((!!(rs485->flags & SER_RS485_RTS_ON_SEND)) ==
> - (!!(rs485->flags & SER_RS485_RTS_AFTER_SEND)))
> - rs485->flags &= ~SER_RS485_ENABLED;
> - else
> - config |= RS485_URA;
> -
> if (rs485->flags & SER_RS485_RTS_ON_SEND)
> config |= RTS_INVERT;
>
> --
> 2.14.2
>
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-23 5:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06 10:49 [PATCH 1/2] serial: 8250_fintek: Return -EINVAL on invalid configuration Ricardo Ribalda Delgado
2017-11-06 10:49 ` [PATCH 2/2] serial: 8250_fintek: Disable delays for ports != 0 Ricardo Ribalda Delgado
2017-11-22 22:31 ` Ricardo Ribalda Delgado
2017-11-22 22:30 ` [PATCH 1/2] serial: 8250_fintek: Return -EINVAL on invalid configuration Ricardo Ribalda Delgado
2017-11-23 5:03 ` Lukas Wunner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox