From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752925AbdKWPWb (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Nov 2017 10:22:31 -0500
Received: from mail.kernel.org ([198.145.29.99]:57784 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752204AbdKWPWa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Nov 2017 10:22:30 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C2BA21924
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Thu, 23 Nov 2017 12:22:27 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ben Gainey <ben.gainey@arm.com>, Stephane Eranian <eranian@google.com>
Cc: Kim Phillips <kim.phillips@arm.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Darren Hart <dvhart@infradead.org>,
        Colin Ian King <colin.king@canonical.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information
 for inlined code
Message-ID: <20171123152227.GG8789@kernel.org>
References: <20171122182541.d25599a3eb1ada3480d142fa@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171122182541.d25599a3eb1ada3480d142fa@arm.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu:
> From: Ben Gainey <ben.gainey@arm.com>
> @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
>  		return -1;
>  	}
>  
> -	flen = strlen(file) + 1;
> +	for (i = 0; i < nr_lines; ++i) {
> +	    flen += strlen(file_names[i]) + 1;
> +	}


Please follow the coding standard used in this file and in tools/perf,
which is the kernel one.

Thanks for providing instructions on how to reproduce the problem!

Stephane, can you please Ack this?

- Arnaldo