Re: [PATCH] xfs: handle register_shrinker error

Michal Hocko
2017-11-23T16:31:19Z

On Fri 24-11-17 01:17:12, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > Hmm, you are right. I have (blindly) followed the current code flow
> > which is wrong as well. The following should do the trick. Should I
> > split that into two patches?
>
> Well, xfs_alloc_buftarg() needs to be more careful.
[...]
> btp = kmem_zalloc(sizeof(*btp), KM_SLEEP | KM_NOFS); // This is GFP_NOFS context. But...
[...]
> if (list_lru_init(&btp->bt_lru)) // This is GFP_KERNEL context.

this sounds like a separate thing to cleanup or document.
--
Michal Hocko
SUSE Labs