Re: [PATCH] frv: fix build failure

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

Hi Alexey,

On Thu, Nov 23, 2017 at 05:17:19PM +0000, Alexey Brodkin wrote:
> Hi Sudip,
> 
> On Tue, 2017-11-21 at 22:10 +0000, Sudip Mukherjee wrote:
> > The frv defconfig build is failing with the error:
> > lib/mpi/mpih-div.o: In function `mpihelp_divrem':
> > mpih-div.c:(.text+0x30c): undefined reference to `abort'
> > 
> > The function 'abort' was never defined for the frv architecture.
> > Create 'abort' as is done in other arch like 'arm' and 'unicore32'.
> > 
> > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> > ---
> 
> I'm seeing the same issue building for ARC from today's Linus' tree.
> Maybe it worth implementing abort() as a weak function for every arch/platform
> that doesn't have it explicitly defined? Otherwise we'll end-up with
> useless code duplication.

Do you mean define it for every arch or define it in a common place so
that all arch can use it?

I did a quick try with the attached patch on two different arch, one of
them (m32r) has the 'abort' defined and the other (frv) was failing due
to lack of abort, and they both built without any warnings or errors.
But I am not sure if 'kernel/exit.c' is the right place for it.
Any suggestion?

--
Regards
Sudip

[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 242 bytes --]

diff --git a/kernel/exit.c b/kernel/exit.c
index af6c245..75ae35a 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1759,3 +1759,7 @@ COMPAT_SYSCALL_DEFINE5(waitid,
 	return -EFAULT;
 }
 #endif
+
+__weak void abort(void) {
+       BUG();
+}