From: Greg KH <gregkh@linuxfoundation.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] schedule: use unlikely()
Date: Sat, 25 Nov 2017 09:56:44 +0100 [thread overview]
Message-ID: <20171125085644.GA1843@kroah.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1711131359030.2791@file01.intranet.prod.int.rdu2.redhat.com>
On Mon, Nov 13, 2017 at 02:00:45PM -0500, Mikulas Patocka wrote:
> A small patch for schedule(), so that the code goes straght in the common
> case.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Was this a measurable difference? If so, great, please provide the
numbers and how you tested in the changelog. If it can't be measured,
then it is not worth it to add these markings as the CPU/compiler almost
always knows better.
thanks,
greg k-h
next prev parent reply other threads:[~2017-11-25 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 19:00 [PATCH] schedule: use unlikely() Mikulas Patocka
2017-11-24 7:38 ` Ingo Molnar
2017-11-24 18:47 ` Mikulas Patocka
2017-11-25 8:16 ` Ingo Molnar
2017-11-28 3:36 ` Mikulas Patocka
2017-11-25 8:56 ` Greg KH [this message]
2017-11-28 0:05 ` Mikulas Patocka
2017-11-28 7:22 ` Greg KH
2017-11-30 7:04 ` Mikulas Patocka
2017-11-30 8:07 ` Greg KH
2017-12-08 14:30 ` Pavel Machek
2017-12-08 14:56 ` Greg KH
2017-12-08 14:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171125085644.GA1843@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mpatocka@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox