From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751196AbdKYI4m (ORCPT ); Sat, 25 Nov 2017 03:56:42 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42188 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbdKYI4l (ORCPT ); Sat, 25 Nov 2017 03:56:41 -0500 Date: Sat, 25 Nov 2017 09:56:44 +0100 From: Greg KH To: Mikulas Patocka Cc: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH] schedule: use unlikely() Message-ID: <20171125085644.GA1843@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 02:00:45PM -0500, Mikulas Patocka wrote: > A small patch for schedule(), so that the code goes straght in the common > case. > > Signed-off-by: Mikulas Patocka Was this a measurable difference? If so, great, please provide the numbers and how you tested in the changelog. If it can't be measured, then it is not worth it to add these markings as the CPU/compiler almost always knows better. thanks, greg k-h