From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751863AbdKYPQX (ORCPT ); Sat, 25 Nov 2017 10:16:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:45058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814AbdKYPQV (ORCPT ); Sat, 25 Nov 2017 10:16:21 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8572219B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sat, 25 Nov 2017 15:16:14 +0000 From: Jonathan Cameron To: Jesse Chan Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Linus Walleij , Rama Krishna Phani A , Philippe Ombredanne , Kate Stewart , Greg Kroah-Hartman , Thomas Gleixner , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: qcom-vadc: add missing MODULE_DESCRIPTION/LICENSE Message-ID: <20171125151614.5d1d96da@archlinux> In-Reply-To: <20171120205601.85296-1-jc@linux.com> References: <20171120205601.85296-1-jc@linux.com> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Nov 2017 12:55:51 -0800 Jesse Chan wrote: > This change resolves a new compile-time warning > when built as a loadable module: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/iio/adc/qcom-vadc-common.o > see include/linux/module.h for more information > > This adds the license as "GPL v2", which matches the header of the file. > > MODULE_DESCRIPTION is also added. > > Signed-off-by: Jesse Chan Again, already handled by Linus Walleij. I'm also far from keen on pushing the header include up into the header... > --- > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 1 - > drivers/iio/adc/qcom-spmi-vadc.c | 1 - > drivers/iio/adc/qcom-vadc-common.c | 3 +++ > drivers/iio/adc/qcom-vadc-common.h | 2 ++ > 4 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > index b093ecddf1a8..e7ba66798362 100644 > --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c > +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > @@ -11,7 +11,6 @@ > > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iio/adc/qcom-spmi-vadc.c b/drivers/iio/adc/qcom-spmi-vadc.c > index 3680e0d47412..569f88ce9385 100644 > --- a/drivers/iio/adc/qcom-spmi-vadc.c > +++ b/drivers/iio/adc/qcom-spmi-vadc.c > @@ -19,7 +19,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c > index 47d24ae5462f..8078a0cbdc46 100644 > --- a/drivers/iio/adc/qcom-vadc-common.c > +++ b/drivers/iio/adc/qcom-vadc-common.c > @@ -229,3 +229,6 @@ int qcom_vadc_decimation_from_dt(u32 value) > return __ffs64(value / VADC_DECIMATION_MIN); > } > EXPORT_SYMBOL(qcom_vadc_decimation_from_dt); > + > +MODULE_DESCRIPTION("Qualcomm voltage ADC driver"); > +MODULE_LICENSE("GPL v2"); > diff --git a/drivers/iio/adc/qcom-vadc-common.h b/drivers/iio/adc/qcom-vadc-common.h > index 1d5354ff5c72..c62500147bb1 100644 > --- a/drivers/iio/adc/qcom-vadc-common.h > +++ b/drivers/iio/adc/qcom-vadc-common.h > @@ -6,6 +6,8 @@ > #ifndef QCOM_VADC_COMMON_H > #define QCOM_VADC_COMMON_H > > +#include > + > #define VADC_CONV_TIME_MIN_US 2000 > #define VADC_CONV_TIME_MAX_US 2100 >