From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751235AbdK0Fwm (ORCPT ); Mon, 27 Nov 2017 00:52:42 -0500 Received: from mga07.intel.com ([134.134.136.100]:23304 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbdK0Fwk (ORCPT ); Mon, 27 Nov 2017 00:52:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,463,1505804400"; d="scan'208";a="6289671" Date: Mon, 27 Nov 2017 11:26:06 +0530 From: Vinod Koul To: Srinivas Kandagatla Cc: gregkh@linuxfoundation.org, broonie@kernel.org, alsa-devel@alsa-project.org, sdharia@codeaurora.org, bp@suse.de, poeschel@lemonage.de, treding@nvidia.com, andreas.noever@gmail.com, alan@linux.intel.com, mathieu.poirier@linaro.org, daniel@ffwll.ch, jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com, davem@davemloft.net, james.hogan@imgtec.com, michael.opdenacker@free-electrons.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH v7 06/13] slimbus: Add messaging APIs to slimbus framework Message-ID: <20171127055606.GR3187@localhost> References: <20171115141043.29202-1-srinivas.kandagatla@linaro.org> <20171115141043.29202-7-srinivas.kandagatla@linaro.org> <20171117074834.GM3187@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 06:47:52AM +0000, Srinivas Kandagatla wrote: > >>+ * -ENOTCONN: If the transmitted message was not ACKed by destination > >>+ * device. > > > >I am preferring ENODATA in SDW for this case, as Slaves didnt respond or > >ACK. > Isn't that a timeout error then. > > ENODATA is for "No data available", reporting ENODATA would be misleading. Do you get a explict NACK or no response for this > > > > >ENOTCONN is defined as /* Transport endpoint is not connected */ which is > >not the case here, connected yes but not responded. > > Code as it is would not return this, so i will be deleting ENOTCONN from > kernel doc. ok -- ~Vinod