From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbdK0Hwu (ORCPT ); Mon, 27 Nov 2017 02:52:50 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34410 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbdK0Hws (ORCPT ); Mon, 27 Nov 2017 02:52:48 -0500 Date: Mon, 27 Nov 2017 08:52:52 +0100 From: Greg KH To: Martin Kepplinger Cc: dmitry.torokhov@gmail.com, pombredanne@nexb.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] input: pegasus_notetaker: add license information Message-ID: <20171127075252.GA19416@kroah.com> References: <20171126004259.xjl2icw3gbyg3hck@dtor-ws> <20171127074401.16388-1-martink@posteo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171127074401.16388-1-martink@posteo.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 08:44:01AM +0100, Martin Kepplinger wrote: > This adds an SPDX license identifier to this driver I wrote some time back. > > Signed-off-by: Martin Kepplinger > --- > > Thanks for the feedback. GPL2+ was what I had in mind. My bad. And as I > already see a lot of SPDX tags using /**/ comments, I'll use that too. > I think if it is hand-written, it shouldn't look too ugly. And in case > that's really a no-go, it seems that many many files need to be changed > again in any case. .h files should be the only ones using /* */, and that is for the ones that break the build if they use // (usually arch-specific and uapi files) So please use // as Linus asked to have done. thanks, greg k-h