From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbdK0Jo4 (ORCPT ); Mon, 27 Nov 2017 04:44:56 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41714 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbdK0Joy (ORCPT ); Mon, 27 Nov 2017 04:44:54 -0500 Date: Mon, 27 Nov 2017 10:44:59 +0100 From: Greg KH To: Laurentiu Tudor Cc: Ruxandra Ioana Radulescu , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , Bogdan Purcareata , Leo Li , "stuyoder@gmail.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] staging: fsl-mc: fix uninitialized variable use Message-ID: <20171127094459.GA25753@kroah.com> References: <20171127090134.19125-1-laurentiu.tudor@nxp.com> <20171127090817.GA14195@kroah.com> <5A1BDB08.5070808@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5A1BDB08.5070808@nxp.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 09:31:21AM +0000, Laurentiu Tudor wrote: > > > On 11/27/2017 11:08 AM, Greg KH wrote: > > On Mon, Nov 27, 2017 at 11:01:34AM +0200, laurentiu.tudor@nxp.com wrote: > >> From: Laurentiu Tudor > >> > >> Fix this warning triggering on a powerpc build: > >> warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized] > >> > >> Signed-off-by: Laurentiu Tudor > >> --- > > > > You forgot a reported-by line :( > > > > And I beat you by about 30 minutes to this patch, sorry about that. > > Sorry, I guess I'm slow on mondays before having my morning coffee. :-( > > > Next time always test-build your patches... > > I did but it didn't show up on my version of powerpc toolchain (gcc > 4.8.1). Maybe it's too old ... Yes, that's really old, please update to something more "modern" :) thanks, greg k-h