From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbdK0J6e (ORCPT ); Mon, 27 Nov 2017 04:58:34 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:37198 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbdK0J6b (ORCPT ); Mon, 27 Nov 2017 04:58:31 -0500 X-Google-Smtp-Source: AGs4zMbDxpD+b5VbPuqvSes/mjnJ8EK+j/CPy54bMkqfG8oKWSJUn2pgDzOdjBlHEgCExxlgxR8Dmw== From: Till Smejkal X-Google-Original-From: Till Smejkal Date: Mon, 27 Nov 2017 10:58:28 +0100 To: Jarkko Sakkinen Cc: platform-driver-x86@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Darren Hart , Andy Shevchenko Subject: Re: [PATCH v6 08/11] intel_sgx: in-kernel launch enclave Message-ID: <20171127095828.GA32603@aton> Mail-Followup-To: Jarkko Sakkinen , platform-driver-x86@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Darren Hart , Andy Shevchenko MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171125193132.24321-9-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Nov 2017, Jarkko Sakkinen wrote: > This commits implements the in-kernel launch enclave. It is wrapped into > a user space program that reads SIGSTRUCT instances from stdin and > outputs launch tokens to stdout. > > The commit also adds enclave signing tool that is used by kbuild to > measure and sign the launch enclave. > > CONFIG_INTEL_SGX_SIGNING_KEY points to a PEM-file for the 3072-bit RSA > key that is used as the LE public key pair. The default location is: > > drivers/platform/x86/intel_sgx/intel_sgx_signing_key.pem ^ signing_key.pem You forgot to change the name of the pem file in the commit message. > > If the default key does not exist kbuild will generate a random key and > place it to this location. KBUILD_SGX_SIGN_PIN can be used to specify > the passphrase for the LE public key. > > TinyCrypt (https://github.com/01org/tinycrypt) is used as AES > implementation, which is not timing resistant. Eventually this needs to > be replaced with AES-NI based implementation that could be either > > - re-use existing AES-NI code in the kernel > - have its own hand written code > > Signed-off-by: Jarkko Sakkinen [...] Cheers Till