* [PATCH] USB: option: add Quectel BG96 2c7c:0296
@ 2017-11-20 18:29 Sebastian Sjoholm
2017-11-27 9:59 ` Johan Hovold
0 siblings, 1 reply; 6+ messages in thread
From: Sebastian Sjoholm @ 2017-11-20 18:29 UTC (permalink / raw)
To: johan; +Cc: gregkh, linux-usb, linux-kernel, Sebastian Sjoholm
Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both
CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel
development board (EVB). The USB id is added to option.c to allow
DIAG,GPS,AT and modem communication with the BG96.
Signed-off-by: Sebastian Sjoholm <ssjoholm@mac.com>
---
drivers/usb/serial/option.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index aaa7d901a06d..3b3513874cfd 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -238,6 +238,7 @@ static void option_instat_callback(struct urb *urb);
/* These Quectel products use Quectel's vendor ID */
#define QUECTEL_PRODUCT_EC21 0x0121
#define QUECTEL_PRODUCT_EC25 0x0125
+#define QUECTEL_PRODUCT_BG96 0x0296
#define CMOTECH_VENDOR_ID 0x16d8
#define CMOTECH_PRODUCT_6001 0x6001
@@ -1182,6 +1183,8 @@ static const struct usb_device_id option_ids[] = {
.driver_info = (kernel_ulong_t)&net_intf4_blacklist },
{ USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25),
.driver_info = (kernel_ulong_t)&net_intf4_blacklist },
+ { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96),
+ .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),
--
2.11.0 (Apple Git-81)
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] USB: option: add Quectel BG96 2c7c:0296
2017-11-20 18:29 [PATCH] USB: option: add Quectel BG96 2c7c:0296 Sebastian Sjoholm
@ 2017-11-27 9:59 ` Johan Hovold
0 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2017-11-27 9:59 UTC (permalink / raw)
To: Sebastian Sjoholm; +Cc: johan, gregkh, linux-usb, linux-kernel
On Mon, Nov 20, 2017 at 07:29:32PM +0100, Sebastian Sjoholm wrote:
> Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both
> CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel
> development board (EVB). The USB id is added to option.c to allow
> DIAG,GPS,AT and modem communication with the BG96.
>
> Signed-off-by: Sebastian Sjoholm <ssjoholm@mac.com>
Thanks for the patch. Now applied for 4.15-rc.
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20171119194028.39679-1-ssjoholm@mac.com>]
* Re: [PATCH] USB: option: add Quectel BG96 2c7c:0296
[not found] <20171119194028.39679-1-ssjoholm@mac.com>
@ 2017-11-20 7:05 ` Greg KH
2017-11-20 17:34 ` Sebastian Sjoholm
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2017-11-20 7:05 UTC (permalink / raw)
To: ssjoholm; +Cc: johan, linux-usb, linux-kernel
On Sun, Nov 19, 2017 at 08:40:28PM +0100, ssjoholm@mac.com wrote:
> From: ssjoholm <ssjoholm@mac.com>
>
> Signed-off-by: ssjoholm <ssjoholm@mac.com>
This goes at the bottom of the changelog text.
And we need a real name, I doubt you use this to sign legal documents.
> Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development board (EVB). The USB id is added to option.c to allow DIAG,GPS,AT and modem communication with the BG96.
Please also line-wrap your text at 72 columns, like your editor is
asking you to :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] USB: option: add Quectel BG96 2c7c:0296
2017-11-20 7:05 ` Greg KH
@ 2017-11-20 17:34 ` Sebastian Sjoholm
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Sjoholm @ 2017-11-20 17:34 UTC (permalink / raw)
To: Greg KH; +Cc: johan, linux-usb, linux-kernel
Thank you for the feedback, let me try once more.
Regards,
Sebastian
> On Nov 20, 2017, at 08:05 , Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, Nov 19, 2017 at 08:40:28PM +0100, ssjoholm@mac.com wrote:
>> From: ssjoholm <ssjoholm@mac.com>
>>
>> Signed-off-by: ssjoholm <ssjoholm@mac.com>
>
> This goes at the bottom of the changelog text.
>
> And we need a real name, I doubt you use this to sign legal documents.
>
>> Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development board (EVB). The USB id is added to option.c to allow DIAG,GPS,AT and modem communication with the BG96.
>
> Please also line-wrap your text at 72 columns, like your editor is
> asking you to :)
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] USB: option: add Quectel BG96 2c7c:0296
@ 2017-11-20 4:19 ssjoholm
0 siblings, 0 replies; 6+ messages in thread
From: ssjoholm @ 2017-11-20 4:19 UTC (permalink / raw)
To: johan; +Cc: gregkh, linux-usb, linux-kernel, ssjoholm
From: ssjoholm <ssjoholm@mac.com>
Signed-off-by: ssjoholm <ssjoholm@mac.com>
Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development board (EVB). The USB id is added to option.c to allow DIAG,GPS,AT and modem communication with the BG96.
---
drivers/usb/serial/option.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index aaa7d901a06d..3b3513874cfd 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -238,6 +238,7 @@ static void option_instat_callback(struct urb *urb);
/* These Quectel products use Quectel's vendor ID */
#define QUECTEL_PRODUCT_EC21 0x0121
#define QUECTEL_PRODUCT_EC25 0x0125
+#define QUECTEL_PRODUCT_BG96 0x0296
#define CMOTECH_VENDOR_ID 0x16d8
#define CMOTECH_PRODUCT_6001 0x6001
@@ -1182,6 +1183,8 @@ static const struct usb_device_id option_ids[] = {
.driver_info = (kernel_ulong_t)&net_intf4_blacklist },
{ USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25),
.driver_info = (kernel_ulong_t)&net_intf4_blacklist },
+ { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96),
+ .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),
--
2.11.0 (Apple Git-81)
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <20171119172801.39103-1-ssjoholm@mac.com>]
* Re: [PATCH] USB: option: add Quectel BG96 2c7c:0296
[not found] <20171119172801.39103-1-ssjoholm@mac.com>
@ 2017-11-19 17:52 ` Sebastian Sjoholm
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Sjoholm @ 2017-11-19 17:52 UTC (permalink / raw)
To: Sebastian Sjoholm; +Cc: johan, gregkh, linux-usb, linux-kernel
Hi All,
Sorry about the patch below, it is not valid, seems that I need to improve my GIT competence.
Please ignore this, and let me try again.
Thank You.
Regards,
Sebastian
> On Nov 19, 2017, at 18:28 , ssjoholm <ssjoholm@mac.com> wrote:
>
> Signed-off-by: ssjoholm <ssjoholm@mac.com>
>
> Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development board (EVB).
>
> The USB id is added to option.c to allow DIAG,GPS,AT and modem communication with the BG96.
> ---
> drivers/usb/serial/option.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index f757e0d2eaf4..3b3513874cfd 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1183,8 +1183,8 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
> { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25),
> .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
> - { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96),
> - .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
> + { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96),
> + .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
> { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
> { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
> { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),
> --
> 2.11.0 (Apple Git-81)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-27 10:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-20 18:29 [PATCH] USB: option: add Quectel BG96 2c7c:0296 Sebastian Sjoholm
2017-11-27 9:59 ` Johan Hovold
[not found] <20171119194028.39679-1-ssjoholm@mac.com>
2017-11-20 7:05 ` Greg KH
2017-11-20 17:34 ` Sebastian Sjoholm
-- strict thread matches above, loose matches on Subject: below --
2017-11-20 4:19 ssjoholm
[not found] <20171119172801.39103-1-ssjoholm@mac.com>
2017-11-19 17:52 ` Sebastian Sjoholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox