From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbdK0LAl (ORCPT ); Mon, 27 Nov 2017 06:00:41 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:38075 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752314AbdK0KtP (ORCPT ); Mon, 27 Nov 2017 05:49:15 -0500 X-Google-Smtp-Source: AGs4zMarC14e1QI23FZFH5nShzFO2Aw1QKspCP59cUcRfyP0+Ii10kOjd7tLvllbAzsus4ZvCzwUzg== From: Bartosz Golaszewski To: Linus Walleij , Bamvor Jian Zhang Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 05/18] gpio: mockup: implement gpio_mockup_err() Date: Mon, 27 Nov 2017 11:48:41 +0100 Message-Id: <20171127104854.333-6-brgl@bgdev.pl> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171127104854.333-1-brgl@bgdev.pl> References: <20171127104854.333-1-brgl@bgdev.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Visually shrink the pr_err() calls by encapsulating adding the module name prefix to the message in a macro. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mockup.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index 5ba8f2089de8..0aa68242f33b 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -34,6 +34,8 @@ */ #define GPIO_MOCKUP_MAX_RANGES (GPIO_MOCKUP_MAX_GC * 2) +#define gpio_mockup_err(...) pr_err(GPIO_MOCKUP_NAME ": " __VA_ARGS__) + enum { GPIO_MOCKUP_DIR_OUT = 0, GPIO_MOCKUP_DIR_IN = 1, @@ -344,13 +346,11 @@ static int __init gpio_mockup_init(void) gpio_mockup_dbg_dir = debugfs_create_dir("gpio-mockup-event", NULL); if (!gpio_mockup_dbg_dir) - pr_err("%s: error creating debugfs directory\n", - GPIO_MOCKUP_NAME); + gpio_mockup_err("error creating debugfs directory\n"); err = platform_driver_register(&gpio_mockup_driver); if (err) { - pr_err("%s: error registering platform driver\n", - GPIO_MOCKUP_NAME); + gpio_mockup_err("error registering platform driver\n"); return err; } @@ -366,8 +366,7 @@ static int __init gpio_mockup_init(void) i, NULL, 0, &pdata, sizeof(pdata)); if (!pdev) { - pr_err("%s: error registering device", - GPIO_MOCKUP_NAME); + gpio_mockup_err("error registering device"); platform_driver_unregister(&gpio_mockup_driver); gpio_mockup_unregister_pdevs(); return -ENOMEM; -- 2.15.0