From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932287AbdK0Q7s (ORCPT ); Mon, 27 Nov 2017 11:59:48 -0500 Received: from muru.com ([72.249.23.125]:52114 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753351AbdK0Q7q (ORCPT ); Mon, 27 Nov 2017 11:59:46 -0500 Date: Mon, 27 Nov 2017 08:59:42 -0800 From: Tony Lindgren To: Keerthy Cc: linux-arm-kernel@lists.infradead.org, rnayak@codeaurora.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, t-kristo@ti.com Subject: Re: [PATCH] ARM: AM33xx: PRM: Remove am33xx_pwrdm_read_prev_pwrst function Message-ID: <20171127165942.GQ28152@atomide.com> References: <1510313212-29660-1-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510313212-29660-1-git-send-email-j-keerthy@ti.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Keerthy [171110 03:29]: > Referring TRM Am335X series: > http://www.ti.com/lit/ug/spruh73p/spruh73p.pdf > > The LastPowerStateEntered bitfield is present only for PM_CEFUSE > domain. This is not present in any of the other power domains. Hence > remove the generic am33xx_pwrdm_read_prev_pwrst hook which wrongly > reads the reserved bit fields for all the other power domains. > > Reading the reserved bits leads to wrongly interpreting the low > power transitions for various power domains that do not have the > LastPowerStateEntered field. The pm debug counters values are wrong > currently as we are incrementing them based on the reserved bits. > > Signed-off-by: Keerthy Applying into omap-for-v4.15/fixes thanks. Tony