From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752385AbdK1VCI (ORCPT ); Tue, 28 Nov 2017 16:02:08 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:48166 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752086AbdK1VCF (ORCPT ); Tue, 28 Nov 2017 16:02:05 -0500 Date: Tue, 28 Nov 2017 16:02:04 -0500 (EST) Message-Id: <20171128.160204.772077471252633195.davem@davemloft.net> To: jhansen@vmware.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, gregkh@linuxfoundation.org, pv-drivers@vmware.com, stefanha@redhat.com Subject: Re: [PATCH] VSOCK: Don't set sk_state to TCP_CLOSE before testing it From: David Miller In-Reply-To: <1511789372-12672-1-git-send-email-jhansen@vmware.com> References: <1511789372-12672-1-git-send-email-jhansen@vmware.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 Nov 2017 13:02:05 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jorgen Hansen Date: Mon, 27 Nov 2017 05:29:32 -0800 > A recent commit (3b4477d2dcf2) converted the sk_state to use > TCP constants. In that change, vmci_transport_handle_detach > was changed such that sk->sk_state was set to TCP_CLOSE before > we test whether it is TCP_SYN_SENT. This change moves the > sk_state change back to the original locations in that function. > > Signed-off-by: Jorgen Hansen Applied.