From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753608AbdK1AYl (ORCPT ); Mon, 27 Nov 2017 19:24:41 -0500 Received: from mga02.intel.com ([134.134.136.20]:6481 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753299AbdK1AXc (ORCPT ); Mon, 27 Nov 2017 19:23:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,466,1505804400"; d="scan'208";a="12682722" From: Andi Kleen To: acme@kernel.org Cc: jolsa@kernel.org, mhiramat@kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: [PATCH 08/12] perf, tools: Always print probe finder warnings with -v Date: Mon, 27 Nov 2017 16:23:17 -0800 Message-Id: <20171128002321.2878-9-andi@firstfloor.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171128002321.2878-1-andi@firstfloor.org> References: <20171128002321.2878-1-andi@firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen Normally perf script debug info resolution doesn't print warnings, but allow -v to override that. Useful for finding out why things don't work. Signed-off-by: Andi Kleen --- tools/perf/util/probe-event.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 4ef6ee967468..fb5031ac24a2 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -482,7 +482,7 @@ static struct debuginfo *open_debuginfo(const char *module, struct nsinfo *nsi, strcpy(reason, "(unknown)"); } else dso__strerror_load(dso, reason, STRERR_BUFSIZE); - if (!silent) + if (!silent || verbose) pr_err("Failed to find the path for %s: %s\n", module ?: "kernel", reason); return NULL; @@ -491,7 +491,7 @@ static struct debuginfo *open_debuginfo(const char *module, struct nsinfo *nsi, } nsinfo__mountns_enter(nsi, &nsc); ret = debuginfo__new(path); - if (!ret && !silent) { + if (!ret && (!silent || verbose)) { pr_warning("The %s file has no debug information.\n", path); if (!module || !strtailcmp(path, ".ko")) pr_warning("Rebuild with CONFIG_DEBUG_INFO=y, "); -- 2.13.6