public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint
Date: Tue, 28 Nov 2017 08:29:01 +0100	[thread overview]
Message-ID: <20171128072901.GD10757@kroah.com> (raw)
In-Reply-To: <1511844744-18232-1-git-send-email-baolu.lu@linux.intel.com>

On Tue, Nov 28, 2017 at 12:52:24PM +0800, Lu Baolu wrote:
> This corrects the endpiont type value set to the DbC bulk in endpoint.
> The previous value doesn't cause any problems because that we now only
> use the bulk out endpoint. Set the hardware with the correct value any
> way.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  drivers/usb/early/xhci-dbc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
> index 8a700b4..e15e896 100644
> --- a/drivers/usb/early/xhci-dbc.c
> +++ b/drivers/usb/early/xhci-dbc.c
> @@ -328,7 +328,7 @@ static void xdbc_mem_init(void)
>  	ep_in = (struct xdbc_ep_context *)&ctx->in;
>  
>  	ep_in->ep_info1		= 0;
> -	ep_in->ep_info2		= cpu_to_le32(EP_TYPE(BULK_OUT_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst));
> +	ep_in->ep_info2		= cpu_to_le32(EP_TYPE(BULK_IN_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst));

Should this go to the stable kernels?  If so, how far back?

thanks,

greg k-h

  reply	other threads:[~2017-11-28  7:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28  4:52 [PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint Lu Baolu
2017-11-28  7:29 ` Greg Kroah-Hartman [this message]
2017-11-28  7:42   ` Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128072901.GD10757@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox