[PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint

[PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint

[Lu Baolu]

This corrects the endpiont type value set to the DbC bulk in endpoint.
The previous value doesn't cause any problems because that we now only
use the bulk out endpoint. Set the hardware with the correct value any
way.

Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/usb/early/xhci-dbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
index 8a700b4..e15e896 100644
--- a/drivers/usb/early/xhci-dbc.c
+++ b/drivers/usb/early/xhci-dbc.c
@@ -328,7 +328,7 @@ static void xdbc_mem_init(void)
 	ep_in = (struct xdbc_ep_context *)&ctx->in;
 
 	ep_in->ep_info1		= 0;
-	ep_in->ep_info2		= cpu_to_le32(EP_TYPE(BULK_OUT_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst));
+	ep_in->ep_info2		= cpu_to_le32(EP_TYPE(BULK_IN_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst));
 	ep_in->deq		= cpu_to_le64(xdbc.in_seg.dma | xdbc.in_ring.cycle_state);
 
 	/* Set DbC context and info registers: */
-- 
2.7.4

Re: [PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint

[Greg Kroah-Hartman]

On Tue, Nov 28, 2017 at 12:52:24PM +0800, Lu Baolu wrote:
> This corrects the endpiont type value set to the DbC bulk in endpoint.
> The previous value doesn't cause any problems because that we now only
> use the bulk out endpoint. Set the hardware with the correct value any
> way.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  drivers/usb/early/xhci-dbc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
> index 8a700b4..e15e896 100644
> --- a/drivers/usb/early/xhci-dbc.c
> +++ b/drivers/usb/early/xhci-dbc.c
> @@ -328,7 +328,7 @@ static void xdbc_mem_init(void)
>  	ep_in = (struct xdbc_ep_context *)&ctx->in;
>  
>  	ep_in->ep_info1		= 0;
> -	ep_in->ep_info2		= cpu_to_le32(EP_TYPE(BULK_OUT_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst));
> +	ep_in->ep_info2		= cpu_to_le32(EP_TYPE(BULK_IN_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst));

Should this go to the stable kernels?  If so, how far back?

thanks,

greg k-h

Re: [PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint

[Lu Baolu]

Hi,

On 11/28/2017 03:29 PM, Greg Kroah-Hartman wrote:
> On Tue, Nov 28, 2017 at 12:52:24PM +0800, Lu Baolu wrote:
>> This corrects the endpiont type value set to the DbC bulk in endpoint.
>> The previous value doesn't cause any problems because that we now only
>> use the bulk out endpoint. Set the hardware with the correct value any
>> way.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> ---
>>  drivers/usb/early/xhci-dbc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
>> index 8a700b4..e15e896 100644
>> --- a/drivers/usb/early/xhci-dbc.c
>> +++ b/drivers/usb/early/xhci-dbc.c
>> @@ -328,7 +328,7 @@ static void xdbc_mem_init(void)
>>  	ep_in = (struct xdbc_ep_context *)&ctx->in;
>>  
>>  	ep_in->ep_info1		= 0;
>> -	ep_in->ep_info2		= cpu_to_le32(EP_TYPE(BULK_OUT_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst));
>> +	ep_in->ep_info2		= cpu_to_le32(EP_TYPE(BULK_IN_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst));
> Should this go to the stable kernels?  If so, how far back?
>

This doesn't cause any real problem. We currently only use
the bulk-out endpoint for early-printk. So I don't think there
is a need to back port it.

Best regards,
Lu Baolu