From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751771AbdK1H26 (ORCPT ); Tue, 28 Nov 2017 02:28:58 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:40272 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbdK1H25 (ORCPT ); Tue, 28 Nov 2017 02:28:57 -0500 Date: Tue, 28 Nov 2017 08:29:01 +0100 From: Greg Kroah-Hartman To: Lu Baolu Cc: Ingo Molnar , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint Message-ID: <20171128072901.GD10757@kroah.com> References: <1511844744-18232-1-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511844744-18232-1-git-send-email-baolu.lu@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 12:52:24PM +0800, Lu Baolu wrote: > This corrects the endpiont type value set to the DbC bulk in endpoint. > The previous value doesn't cause any problems because that we now only > use the bulk out endpoint. Set the hardware with the correct value any > way. > > Signed-off-by: Lu Baolu > --- > drivers/usb/early/xhci-dbc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c > index 8a700b4..e15e896 100644 > --- a/drivers/usb/early/xhci-dbc.c > +++ b/drivers/usb/early/xhci-dbc.c > @@ -328,7 +328,7 @@ static void xdbc_mem_init(void) > ep_in = (struct xdbc_ep_context *)&ctx->in; > > ep_in->ep_info1 = 0; > - ep_in->ep_info2 = cpu_to_le32(EP_TYPE(BULK_OUT_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst)); > + ep_in->ep_info2 = cpu_to_le32(EP_TYPE(BULK_IN_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst)); Should this go to the stable kernels? If so, how far back? thanks, greg k-h