From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752155AbdK1IrX (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 03:47:23 -0500
Received: from mail-lf0-f43.google.com ([209.85.215.43]:35537 "EHLO
        mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751063AbdK1IrV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 03:47:21 -0500
X-Google-Smtp-Source: AGs4zMZzr95O5rALKpPKzMD07QO6uambllWJEACWMJpoqd5Pr+OxIKd73GgEJGaOkVFHtofx/w2kdA==
Date: Tue, 28 Nov 2017 09:47:15 +0100
From: Johan Hovold <johan@kernel.org>
To: Gimcuan Hui <gimcuan@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, gregkh@linuxfoundation.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: Clean up the return values of read_reg and
 write_reg
Message-ID: <20171128084715.GF9862@localhost>
References: <20171127153651.2115-1-gimcuan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171127153651.2115-1-gimcuan@gmail.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 27, 2017 at 03:36:51PM +0000, Gimcuan Hui wrote:
> write_reg returns 0 on success, we can make it more explicit by returning
> number 0 instead of result variable.
> 
> read_reg should return 0 on success since this is a more common pattern.
> 
> The user of read_reg has been clean-up and should be at the same commit.
> 
> Signed-off-by: Gimcuan Hui <gimcuan@gmail.com>

Thanks for the update. Now applied for -next with a slightly modified
summary:

	USB: serial: ark3116: clean up return values of register accessors

Johan