From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755263AbdK1LM3 (ORCPT ); Tue, 28 Nov 2017 06:12:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45214 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755221AbdK1LMZ (ORCPT ); Tue, 28 Nov 2017 06:12:25 -0500 Date: Tue, 28 Nov 2017 12:12:22 +0100 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v2 04/10] perf util: Add rbtree node_delete ops Message-ID: <20171128111222.GB2732@krava> References: <1511791650-24072-1-git-send-email-yao.jin@linux.intel.com> <1511791650-24072-5-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511791650-24072-5-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 28 Nov 2017 11:12:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 10:07:24PM +0800, Jin Yao wrote: SNIP > @@ -124,13 +137,25 @@ static struct saved_value *saved_value_lookup(struct perf_evsel *evsel, > return NULL; > } > > +void runtime_stat__init(struct runtime_stat *stat) > +{ > + struct rblist *rblist = &stat->value_list; > + > + rblist__init(rblist); > + rblist->node_cmp = saved_value_cmp; > + rblist->node_new = saved_value_new; > + rblist->node_delete = saved_value_delete; > +} > + > +void runtime_stat__free(struct runtime_stat *stat) > +{ > + rblist__reset(&stat->value_list); > +} > + > void perf_stat__init_shadow_stats(void) > { > have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend"); > - rblist__init(&runtime_saved_values); > - runtime_saved_values.node_cmp = saved_value_cmp; > - runtime_saved_values.node_new = saved_value_new; > - /* No delete for now */ hum, you should you remove this at the switching point to keep it bisectable.. now it crashes: [jolsa@krava perf]$ sudo ./perf stat -M Summary --metric-only -a sleep 1 Segmentation fault jirka