From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932540AbdK1LMg (ORCPT ); Tue, 28 Nov 2017 06:12:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39122 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754998AbdK1LMd (ORCPT ); Tue, 28 Nov 2017 06:12:33 -0500 Date: Tue, 28 Nov 2017 12:12:28 +0100 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v2 04/10] perf util: Add rbtree node_delete ops Message-ID: <20171128111228.GC2732@krava> References: <1511791650-24072-1-git-send-email-yao.jin@linux.intel.com> <1511791650-24072-5-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511791650-24072-5-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 28 Nov 2017 11:12:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 10:07:24PM +0800, Jin Yao wrote: > In current stat-shadow.c, the rbtree deleting is ignored. > > The patch reconstructs the code of rblist init/free, and adds > the implementation to node_delete method of rblist. > > Signed-off-by: Jin Yao > --- > tools/perf/util/stat-shadow.c | 33 +++++++++++++++++++++++++++++---- > tools/perf/util/stat.h | 3 +++ > 2 files changed, 32 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c > index c53b80d..0fdd2aa 100644 > --- a/tools/perf/util/stat-shadow.c > +++ b/tools/perf/util/stat-shadow.c > @@ -40,6 +40,7 @@ static struct stats runtime_aperf_stats[NUM_CTX][MAX_NR_CPUS]; > static struct rblist runtime_saved_values; > static bool have_frontend_stalled; > > +struct runtime_stat rt_stat; > struct stats walltime_nsecs_stats; > > struct saved_value { > @@ -103,6 +104,18 @@ static struct rb_node *saved_value_new(struct rblist *rblist __maybe_unused, > return &nd->rb_node; > } > > +static void saved_value_delete(struct rblist *rblist __maybe_unused, > + struct rb_node *rb_node) > +{ > + struct saved_value *v; > + > + BUG_ON(!rb_node); > + v = container_of(rb_node, > + struct saved_value, > + rb_node); any reason for this to be cut on 3 lines? single line wouldn't cross 80 chars length.. jirka