* [PATCH] block: Add default switch case to blk_pm_allow_request() to kill warning
@ 2017-11-27 20:40 Geert Uytterhoeven
2017-11-28 12:44 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2017-11-27 20:40 UTC (permalink / raw)
To: Jens Axboe, Christoph Hellwig
Cc: Arnd Bergmann, linux-block, linux-kernel, Geert Uytterhoeven
With gcc 4.9.0:
block/blk-core.c: In function 'blk_pm_allow_request':
block/blk-core.c:2607:2: warning: enumeration value 'RPM_ACTIVE' not handled in switch [-Wswitch]
switch (rq->q->rpm_status) {
^
Convert the return statement below the switch() block into a default
case to fix this.
Fixes: e4f36b249b4d4e75 ("block: fix peeking requests during PM")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
block/blk-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index b8881750a3acd705..579e683c95e26049 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2610,9 +2610,9 @@ static bool blk_pm_allow_request(struct request *rq)
return rq->rq_flags & RQF_PM;
case RPM_SUSPENDED:
return false;
+ default:
+ return true;
}
-
- return true;
}
#else
static bool blk_pm_allow_request(struct request *rq)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: Add default switch case to blk_pm_allow_request() to kill warning
2017-11-27 20:40 [PATCH] block: Add default switch case to blk_pm_allow_request() to kill warning Geert Uytterhoeven
@ 2017-11-28 12:44 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2017-11-28 12:44 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jens Axboe, Christoph Hellwig, Arnd Bergmann, linux-block,
linux-kernel
What an annoying compiler :)
But otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-28 12:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-27 20:40 [PATCH] block: Add default switch case to blk_pm_allow_request() to kill warning Geert Uytterhoeven
2017-11-28 12:44 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox