From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752600AbdK1NBx (ORCPT ); Tue, 28 Nov 2017 08:01:53 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46920 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752461AbdK1NBu (ORCPT ); Tue, 28 Nov 2017 08:01:50 -0500 Date: Tue, 28 Nov 2017 14:01:54 +0100 From: Greg KH To: Chase Metzger Cc: Marcus Wolf , Joseph Wright , Colin Ian King , Haneen Mohammed , Elia Geretto , Srishti Sharma , Xiangyang Zhang , Derek Robson , Cihangir Akturk , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues Message-ID: <20171128130154.GA20829@kroah.com> References: <20171114200357.4628-1-chasemetzger15@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171114200357.4628-1-chasemetzger15@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2017 at 12:03:51PM -0800, Chase Metzger wrote: > Fix if/else if and braces in function DIO0_irq_handler to comply with > the kernel coding style. > > Signed-off-by: Chase Metzger > --- > drivers/staging/pi433/pi433_if.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c > index d946838450d4..dee70c47629c 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -133,19 +133,14 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id) > { > struct pi433_device *device = dev_id; > > - if (device->irq_state[DIO0] == DIO_PacketSent) > - { > + if (device->irq_state[DIO0] == DIO_PacketSent) { When you are touching the line, be sure to fix the obvious space issue here as well. thanks, greg k-h