From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbdK1NoR (ORCPT ); Tue, 28 Nov 2017 08:44:17 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:37059 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753006AbdK1NoK (ORCPT ); Tue, 28 Nov 2017 08:44:10 -0500 Date: Tue, 28 Nov 2017 14:43:58 +0100 From: Andrew Lunn To: Antoine Tenart Cc: rmk@armlinux.org.uk, f.fainelli@gmail.com, davem@davemloft.net, gregory.clement@free-electrons.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: phy: marvell10g: fix the PHY id mask Message-ID: <20171128134358.GC20797@lunn.ch> References: <20171128132630.26619-1-antoine.tenart@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171128132630.26619-1-antoine.tenart@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 02:26:30PM +0100, Antoine Tenart wrote: > The Marvell 10G PHY driver supports different hardware revisions, which > have their bits 3..0 differing. To get the correct revision number these > bits should be ignored. This patch fixes this by using the already > defined MARVELL_PHY_ID_MASK (0xfffffff0) instead of the custom > 0xffffffff mask. > > Fixes: 20b2af32ff3f ("net: phy: add Marvell Alaska X 88X3310 10Gigabit PHY support") > Suggested-by: Yan Markman > Signed-off-by: Antoine Tenart Reviewed-by: Andrew Lunn Andrew