From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753876AbdK1PET (ORCPT ); Tue, 28 Nov 2017 10:04:19 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37274 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752750AbdK1PEO (ORCPT ); Tue, 28 Nov 2017 10:04:14 -0500 Date: Tue, 28 Nov 2017 16:04:18 +0100 From: Greg Kroah-Hartman To: Johan Hovold Cc: Rob Herring , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] serdev: ttyport: do not used keyed wakeup in write_wakeup Message-ID: <20171128150418.GA3341@kroah.com> References: <20171103143059.20749-1-johan@kernel.org> <20171103143059.20749-9-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171103143059.20749-9-johan@kernel.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 03, 2017 at 03:30:59PM +0100, Johan Hovold wrote: > Serdev does not use the file abstraction and specifically there will > never be anyone polling a file descriptor for POLLOUT events. > > Just use plain wake_up_interruptible() in the write_wakeup callback and > document why it's there. > > Signed-off-by: Johan Hovold > --- > drivers/tty/serdev/serdev-ttyport.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This patch didn't apply, perhaps because I split this series across my "for-next" and "for-linus" branches? thanks, greg k-h