From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbdK1PQg (ORCPT ); Tue, 28 Nov 2017 10:16:36 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:37656 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258AbdK1PQd (ORCPT ); Tue, 28 Nov 2017 10:16:33 -0500 X-Google-Smtp-Source: AGs4zMaT98IcKrALZ1XMdSo/3ZO5wLRDW/hUNTM8f2j3j5eWbtas2PAOPfaS3bJi2AW2J/FnsILedA== Date: Tue, 28 Nov 2017 16:16:29 +0100 From: Johan Hovold To: Greg Kroah-Hartman Cc: Johan Hovold , Rob Herring , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] serdev: ttyport: do not used keyed wakeup in write_wakeup Message-ID: <20171128151629.GA8177@localhost> References: <20171103143059.20749-1-johan@kernel.org> <20171103143059.20749-9-johan@kernel.org> <20171128150418.GA3341@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171128150418.GA3341@kroah.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 04:04:18PM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 03, 2017 at 03:30:59PM +0100, Johan Hovold wrote: > > Serdev does not use the file abstraction and specifically there will > > never be anyone polling a file descriptor for POLLOUT events. > > > > Just use plain wake_up_interruptible() in the write_wakeup callback and > > document why it's there. > > > > Signed-off-by: Johan Hovold > > --- > > drivers/tty/serdev/serdev-ttyport.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > This patch didn't apply, perhaps because I split this series across my > "for-next" and "for-linus" branches? That's right, this one depends on patch 4/8. Perhaps you can take also this one through tty-linus? Or even better, just take the whole series through tty-linus? Johan