Re: [PATCH 8/8] serdev: ttyport: do not used keyed wakeup in write_wakeup

Greg Kroah-Hartman
2017-11-28T19:39:24Z

On Tue, Nov 28, 2017 at 04:16:29PM +0100, Johan Hovold wrote:
> On Tue, Nov 28, 2017 at 04:04:18PM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Nov 03, 2017 at 03:30:59PM +0100, Johan Hovold wrote:
> > > Serdev does not use the file abstraction and specifically there will
> > > never be anyone polling a file descriptor for POLLOUT events.
> > >
> > > Just use plain wake_up_interruptible() in the write_wakeup callback and
> > > document why it's there.
> > >
> > > Signed-off-by: Johan Hovold <johan@kernel.org>
> > > ---
> > > drivers/tty/serdev/serdev-ttyport.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > This patch didn't apply, perhaps because I split this series across my
> > "for-next" and "for-linus" branches?
>
> That's right, this one depends on patch 4/8.
>
> Perhaps you can take also this one through tty-linus? Or even better,
> just take the whole series through tty-linus?

They all didn't feel like patches to go in after -rc1, right?
Documentation updates? Minor tweaks? Would you want to defend them?
:)

thanks,

greg k-h