From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754023AbdK1QBE (ORCPT ); Tue, 28 Nov 2017 11:01:04 -0500 Received: from muru.com ([72.249.23.125]:52348 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707AbdK1QBC (ORCPT ); Tue, 28 Nov 2017 11:01:02 -0500 Date: Tue, 28 Nov 2017 08:00:57 -0800 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Russell King , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Subject: Re: [PATCH v2 2/4] DTS: GTA04: fix panel compatibility string Message-ID: <20171128160057.GB28152@atomide.com> References: <09d975dd62afa1dfa43d94079cc9a44731af4b3b.1510822218.git.hns@goldelico.com> <20171128145727.GY28152@atomide.com> <20171128151039.GZ28152@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * H. Nikolaus Schaller [171128 15:51]: > > Am 28.11.2017 um 16:10 schrieb Tony Lindgren : > > OK fine dropping both. Please update the description in both dts > > patches to make it clear they are needed as a fix. Preferrably > > with a proper fixes tag. > > Well, it is not "needed" in a strong sense since current mainline&stable > works. It is more a style and consistency fix to use "tpo," everywhere. > > > > > Having "We can remove the "omapdss," prefix" in the description sure > > does not sounds like it's needed as a fix :) > > The description has been improved on -v3. Thanks. > > Sounds like maybe these two should be just a single patch for > > a proper fix? > > Hm. I usually get the feedback to separate DT and driver fixes into > separate commits... Therefore I submit patch sets in the hope they > are not picked apart :) See "both dts patches" part above. Yes the dts patches can and should be sent separately. In almost every case if the dts patches cannot be applied separately it means your driver changes are breaking things. Regards, Tony