From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754163AbdK1TjY (ORCPT ); Tue, 28 Nov 2017 14:39:24 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56004 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbdK1TjW (ORCPT ); Tue, 28 Nov 2017 14:39:22 -0500 Date: Tue, 28 Nov 2017 20:39:26 +0100 From: Greg Kroah-Hartman To: Johan Hovold Cc: Rob Herring , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] serdev: ttyport: do not used keyed wakeup in write_wakeup Message-ID: <20171128193926.GA1696@kroah.com> References: <20171103143059.20749-1-johan@kernel.org> <20171103143059.20749-9-johan@kernel.org> <20171128150418.GA3341@kroah.com> <20171128151629.GA8177@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171128151629.GA8177@localhost> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 04:16:29PM +0100, Johan Hovold wrote: > On Tue, Nov 28, 2017 at 04:04:18PM +0100, Greg Kroah-Hartman wrote: > > On Fri, Nov 03, 2017 at 03:30:59PM +0100, Johan Hovold wrote: > > > Serdev does not use the file abstraction and specifically there will > > > never be anyone polling a file descriptor for POLLOUT events. > > > > > > Just use plain wake_up_interruptible() in the write_wakeup callback and > > > document why it's there. > > > > > > Signed-off-by: Johan Hovold > > > --- > > > drivers/tty/serdev/serdev-ttyport.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > This patch didn't apply, perhaps because I split this series across my > > "for-next" and "for-linus" branches? > > That's right, this one depends on patch 4/8. > > Perhaps you can take also this one through tty-linus? Or even better, > just take the whole series through tty-linus? They all didn't feel like patches to go in after -rc1, right? Documentation updates? Minor tweaks? Would you want to defend them? :) thanks, greg k-h