From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754361AbdK1UmX (ORCPT ); Tue, 28 Nov 2017 15:42:23 -0500 Received: from mga04.intel.com ([192.55.52.120]:43843 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754314AbdK1UmU (ORCPT ); Tue, 28 Nov 2017 15:42:20 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,468,1505804400"; d="scan'208";a="154137720" Date: Tue, 28 Nov 2017 22:42:20 +0200 From: Jarkko Sakkinen To: Christoph Hellwig Cc: platform-driver-x86@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Alexander Viro , "open list:FILESYSTEMS (VFS and infrastructure)" Subject: Re: [PATCH v6 09/11] fs/pipe.c: export create_pipe_files() and replace_fd() Message-ID: <20171128204220.j7ipouoyhsbvm7zk@linux.intel.com> References: <20171125193132.24321-1-jarkko.sakkinen@linux.intel.com> <20171125193132.24321-10-jarkko.sakkinen@linux.intel.com> <20171128143504.GA22918@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171128143504.GA22918@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 06:35:04AM -0800, Christoph Hellwig wrote: > Repeated NAK - any interface that deals with raw file descriptor table > entries has absolutely no business in a driver. > > Please fix your API already. Does it make a differnece if the code is moved to arch/x86, which could potentially happen (see Darren's and tglx's comments on v5)? Then the need for export will be gone. /Jarkko