From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752845AbdK1Vde (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 16:33:34 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:38470 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752607AbdK1Vda (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 16:33:30 -0500
Date: Tue, 28 Nov 2017 22:33:27 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Shrikrishna Khare <skhare@vmware.com>
Cc: pv-drivers@vmware.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] vmxnet3: increase default rx ring sizes
Message-ID: <20171128213327.GJ14512@lunn.ch>
References: <20171128211204.12234-1-skhare@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171128211204.12234-1-skhare@vmware.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>  /*
>   * Version numbers
>   */
> -#define VMXNET3_DRIVER_VERSION_STRING   "1.4.a.0-k"
> +#define VMXNET3_DRIVER_VERSION_STRING   "1.4.11.0-k"
>  
>  /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */
> -#define VMXNET3_DRIVER_VERSION_NUM      0x01040a00
> +#define VMXNET3_DRIVER_VERSION_NUM      0x01040b00

Version strings in drivers are totally pointless, but should not this
be 0x01041100?

   Andrew