From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbdK2Djq (ORCPT ); Tue, 28 Nov 2017 22:39:46 -0500 Received: from one.firstfloor.org ([193.170.194.197]:34644 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbdK2Djp (ORCPT ); Tue, 28 Nov 2017 22:39:45 -0500 Date: Tue, 28 Nov 2017 19:39:43 -0800 From: Andi Kleen To: Masami Hiramatsu Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 06/12] perf, tools, probe: Support a quiet argument for debug info open Message-ID: <20171129033943.GA2482@two.firstfloor.org> References: <20171128002321.2878-1-andi@firstfloor.org> <20171128002321.2878-7-andi@firstfloor.org> <20171129121400.9ded2948615eaaf110bbec7e@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171129121400.9ded2948615eaaf110bbec7e@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29, 2017 at 12:14:00PM +0900, Masami Hiramatsu wrote: > On Mon, 27 Nov 2017 16:23:15 -0800 > Andi Kleen wrote: > > > From: Andi Kleen > > > > Add a extra quiet argument to the debug info open / probe finder > > code that allows perf script to make them quieter. Otherwise > > we may end up with too many error messages when lots of > > instructions fail debug info parsing. > > IMHO, this kind of simple suppress warning message would better > be done with pr_* implementation (or its macro) since there > maybe new message added or other function which has warning > messages can be called in the future. Do you really mean adding a special pr_ / global just for this case? Seems less clean to me, but I can do it. -Andi