From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbdK2G4T (ORCPT ); Wed, 29 Nov 2017 01:56:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:41878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbdK2G4R (ORCPT ); Wed, 29 Nov 2017 01:56:17 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AED5B217C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Wed, 29 Nov 2017 14:55:59 +0800 From: Shawn Guo To: "Y.b. Lu" Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Rob Herring , Mark Rutland , Russell King Subject: Re: [PATCH] arm: dts: ls1021a: fix the value of TMR_FIPER1 Message-ID: <20171129065558.GK9376@dragon> References: <20171110015847.29635-1-yangbo.lu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 24, 2017 at 02:31:13AM +0000, Y.b. Lu wrote: > Any comments? > > +Shawn Please resend with me on copy. > > Thanks. > > -----Original Message----- > From: Yangbo Lu [mailto:yangbo.lu@nxp.com] > Sent: 2017年11月10日 9:59 > To: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Rob Herring ; Mark Rutland ; Russell King > Cc: Y.b. Lu > Subject: [PATCH] arm: dts: ls1021a: fix the value of TMR_FIPER1 ARM: dts: ... > > The timer fixed interval period pulse generator register is used to generate periodic pulses. The down count register loads the value programmed in the fixed period interval (FIPER). At every tick of the timer accumulator overflow, the counter decrements by the value of TMR_CTRL[TCLK_PERIOD]. It generates a pulse when the down counter value reaches zero. It reloads the down counter in the cycle following a pulse. To use the TMR_FIPER1 register to generate a 1 PPS event, the value Please wrap the commit log properly. Shawn > (10^9 nanoseconds) - TCLK_PERIOD should be programmed. > It should be 999999995 not 999999990 since TCLK_PERIOD is 5. > > Signed-off-by: Yangbo Lu > --- > arch/arm/boot/dts/ls1021a.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index 9319e1f0f1d8..10e536f338f7 100644 > --- a/arch/arm/boot/dts/ls1021a.dtsi > +++ b/arch/arm/boot/dts/ls1021a.dtsi > @@ -575,7 +575,7 @@ > fsl,tclk-period = <5>; > fsl,tmr-prsc = <2>; > fsl,tmr-add = <0xaaaaaaab>; > - fsl,tmr-fiper1 = <999999990>; > + fsl,tmr-fiper1 = <999999995>; > fsl,tmr-fiper2 = <99990>; > fsl,max-adj = <499999999>; > }; > -- > 2.14.1 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel