From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754320AbdK2K2N (ORCPT ); Wed, 29 Nov 2017 05:28:13 -0500 Received: from mga03.intel.com ([134.134.136.65]:48504 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754053AbdK2K2J (ORCPT ); Wed, 29 Nov 2017 05:28:09 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,472,1505804400"; d="scan'208";a="181894158" Date: Wed, 29 Nov 2017 16:01:41 +0530 From: Vinod Koul To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, torvalds@linux-foundation.org, liam.r.girdwood@linux.intel.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 5/7] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell Message-ID: <20171129103140.GB32417@localhost> References: <20171129014551.30552-1-pierre-louis.bossart@linux.intel.com> <20171129014551.30552-6-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171129014551.30552-6-pierre-louis.bossart@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 07:45:49PM -0600, Pierre-Louis Bossart wrote: > Make sure that the same I2C/I2C_DESIGNWARE_PLATFORM are selected. > The latter might actually need to be moved to the SOC side of things, > it really has no place in a machine driver dependency not really, given that we will come with platforms where I2C may not be used for audio, we should keep this in machine or better move to codecs as it belongs to them, machine being second best :) > > Signed-off-by: Pierre-Louis Bossart > --- > sound/soc/intel/boards/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig > index df41a6016217..a1e169c86526 100644 > --- a/sound/soc/intel/boards/Kconfig > +++ b/sound/soc/intel/boards/Kconfig > @@ -42,7 +42,7 @@ config SND_SOC_INTEL_HASWELL_MACH > > config SND_SOC_INTEL_BDW_RT5677_MACH > tristate "ASoC Audio driver for Intel Broadwell with RT5677 codec" > - depends on X86_INTEL_LPSS && GPIOLIB && I2C > + depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM && GPIOLIB > select SND_SOC_RT5677 > help > This adds support for Intel Broadwell platform based boards with > -- > 2.14.1 > -- ~Vinod