From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbdK2DQR (ORCPT ); Tue, 28 Nov 2017 22:16:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:50772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbdK2DQQ (ORCPT ); Tue, 28 Nov 2017 22:16:16 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9938218DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Wed, 29 Nov 2017 12:16:13 +0900 From: Masami Hiramatsu To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mhiramat@kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 08/12] perf, tools: Always print probe finder warnings with -v Message-Id: <20171129121613.85f25039192164225b70da68@kernel.org> In-Reply-To: <20171128002321.2878-9-andi@firstfloor.org> References: <20171128002321.2878-1-andi@firstfloor.org> <20171128002321.2878-9-andi@firstfloor.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Nov 2017 16:23:17 -0800 Andi Kleen wrote: > From: Andi Kleen > > Normally perf script debug info resolution doesn't print > warnings, but allow -v to override that. Useful for finding out why > things don't work. This must be done in call-site, since we don't need it clearly in below case. ---- /* Try to find perf_probe_event with debuginfo */ static int try_to_find_probe_trace_events(struct perf_probe_event *pev, struct probe_trace_event **tevs) { bool need_dwarf = perf_probe_event_need_dwarf(pev); struct perf_probe_point tmp; struct debuginfo *dinfo; int ntevs, ret = 0; dinfo = open_debuginfo(pev->target, pev->nsi, !need_dwarf); ---- Thanks, > > Signed-off-by: Andi Kleen > --- > tools/perf/util/probe-event.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 4ef6ee967468..fb5031ac24a2 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -482,7 +482,7 @@ static struct debuginfo *open_debuginfo(const char *module, struct nsinfo *nsi, > strcpy(reason, "(unknown)"); > } else > dso__strerror_load(dso, reason, STRERR_BUFSIZE); > - if (!silent) > + if (!silent || verbose) > pr_err("Failed to find the path for %s: %s\n", > module ?: "kernel", reason); > return NULL; > @@ -491,7 +491,7 @@ static struct debuginfo *open_debuginfo(const char *module, struct nsinfo *nsi, > } > nsinfo__mountns_enter(nsi, &nsc); > ret = debuginfo__new(path); > - if (!ret && !silent) { > + if (!ret && (!silent || verbose)) { > pr_warning("The %s file has no debug information.\n", path); > if (!module || !strtailcmp(path, ".ko")) > pr_warning("Rebuild with CONFIG_DEBUG_INFO=y, "); > -- > 2.13.6 > -- Masami Hiramatsu