From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469AbdK2N5t (ORCPT ); Wed, 29 Nov 2017 08:57:49 -0500 Received: from mga07.intel.com ([134.134.136.100]:24144 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752802AbdK2N5r (ORCPT ); Wed, 29 Nov 2017 08:57:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,473,1505804400"; d="scan'208";a="13338518" Date: Wed, 29 Nov 2017 19:31:18 +0530 From: Vinod Koul To: Sinan Kaya Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: qcom_hidma: check pending interrupts Message-ID: <20171129140118.GF32417@localhost> References: <1510671301-23223-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510671301-23223-1-git-send-email-okaya@codeaurora.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2017 at 09:55:01AM -0500, Sinan Kaya wrote: > Driver is missing the interrupts if two requests are queued up at the same > time as the interrupt handler is servicing a request that was just > delivered. > > The ISR clears the interrupt at the end but it could be clearing the > interrupt for an outstanding event. Therefore, second interrupt never > arrives. > > Clear the interrupt first and then check for completions. > > Also, make sure that request start and interrupt clear do not overlap in > time by using a spinlock. Applied, thanks -- ~Vinod