From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932728AbdK2OQB (ORCPT ); Wed, 29 Nov 2017 09:16:01 -0500 Received: from mga14.intel.com ([192.55.52.115]:53156 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754198AbdK2OP6 (ORCPT ); Wed, 29 Nov 2017 09:15:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,473,1505804400"; d="scan'208";a="154380551" Date: Wed, 29 Nov 2017 19:49:30 +0530 From: Vinod Koul To: "Gustavo A. R. Silva" Cc: Ludovic Desroches , Dan Williams , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: at_hdmac: fix potential NULL pointer dereference in atc_prep_dma_interleaved Message-ID: <20171129141930.GJ32417@localhost> References: <20171120142814.GA3315@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171120142814.GA3315@embeddedor.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 08:28:14AM -0600, Gustavo A. R. Silva wrote: > _xt_ is being dereferenced before it is null checked, hence there is a > potential null pointer dereference. > > Fix this by moving the pointer dereference after _xt_ has been null > checked. > > This issue was detected with the help of Coccinelle. Applied, thanks -- ~Vinod