From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933688AbdK2QvD (ORCPT ); Wed, 29 Nov 2017 11:51:03 -0500 Received: from muru.com ([72.249.23.125]:52534 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753457AbdK2Qux (ORCPT ); Wed, 29 Nov 2017 11:50:53 -0500 Date: Wed, 29 Nov 2017 08:50:50 -0800 From: Tony Lindgren To: Stephen Rothwell Cc: Linux-Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: Signed-off-by missing for commit in the omap tree Message-ID: <20171129165050.GG28152@atomide.com> References: <20171129093017.5e69ad0d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171129093017.5e69ad0d@canb.auug.org.au> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Stephen Rothwell [171128 22:32]: > Hi Tony, > > Commit > > 57af8b4f7b46 ("Revert "ARM: omap2plus: Run make savedefconfig again to save some space"") > > is missing a Signed-off-by from its author or committer. > > Also, it is nice to put some reasoning in the commit message for a revert > so future you knows why you did it. Thanks for letting me know, that's no longer in my for-next branch. And yes, I should have added a proper commit message to the revert. Regards, Tony