From: Tony Lindgren <tony@atomide.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
ckeepax@opensource.cirrus.com,
ckeepax@opensource.wolfsonmicro.com, swarren@nvidia.com,
andy.shevchenko@gmail.com, alcooperx@gmail.com,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 1/2] pinctrl: Allow a device to indicate when to force a state
Date: Wed, 29 Nov 2017 09:01:02 -0800 [thread overview]
Message-ID: <20171129170102.GH28152@atomide.com> (raw)
In-Reply-To: <20171102231551.16220-2-f.fainelli@gmail.com>
* Florian Fainelli <f.fainelli@gmail.com> [171102 23:18]:
> It may happen that a device needs to force applying a state, e.g:
> because it only defines one state of pin states (default) but loses
> power/register contents when entering low power modes. Add a
> pinctrl_dev::flags bitmask to help describe future quirks and define
> PINCTRL_FLG_FORCE_STATE as such a settable flag.
It makes sense to tag the existing state with the context loss
information as otherwise we'll be duplicating the state in the
pinctrl driver potentially for hundreds of pins.
Maybe this patch description should clarify that it's the
pinctrl device restoring the pin state, not the pinctrl
consumer devices?
So maybe just "a pinctrl device needs to force apply a state"
instead of just device above?
Regards,
Tony
next prev parent reply other threads:[~2017-11-29 17:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 23:15 [PATCH v2 0/2] pinctrl: Allow indicating loss of state across suspend/resume Florian Fainelli
2017-11-02 23:15 ` [PATCH v2 1/2] pinctrl: Allow a device to indicate when to force a state Florian Fainelli
2017-11-29 13:06 ` Linus Walleij
2017-11-29 17:01 ` Tony Lindgren [this message]
2017-11-29 17:35 ` Florian Fainelli
2017-11-29 17:45 ` Tony Lindgren
2017-11-29 18:15 ` Florian Fainelli
2017-11-29 18:27 ` Tony Lindgren
2017-11-02 23:15 ` [PATCH v2 2/2] pinctrl: Allow indicating loss of pin states during low-power Florian Fainelli
2017-11-29 13:01 ` Linus Walleij
2017-11-29 17:02 ` Tony Lindgren
2017-11-29 17:37 ` Florian Fainelli
2017-12-02 12:48 ` Linus Walleij
2017-12-10 23:38 ` Florian Fainelli
2017-12-20 7:24 ` Linus Walleij
2017-12-30 19:31 ` Florian Fainelli
2017-11-03 10:37 ` [PATCH v2 0/2] pinctrl: Allow indicating loss of state across suspend/resume Charles Keepax
2017-11-03 16:11 ` Tony Lindgren
2017-11-03 17:02 ` Florian Fainelli
2017-11-03 17:33 ` Tony Lindgren
2017-11-04 8:37 ` Charles Keepax
2017-11-07 16:00 ` Tony Lindgren
2017-11-04 12:25 ` Rafael J. Wysocki
2017-11-04 17:19 ` Florian Fainelli
2017-11-07 16:00 ` Tony Lindgren
2017-11-08 0:23 ` Rafael J. Wysocki
2017-11-08 0:28 ` Florian Fainelli
2017-11-08 0:45 ` Rafael J. Wysocki
2017-11-08 1:04 ` Tony Lindgren
2017-11-08 1:02 ` Tony Lindgren
2017-11-03 17:03 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129170102.GH28152@atomide.com \
--to=tony@atomide.com \
--cc=alcooperx@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).